Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "PB-296: Add failOnError to all layers" #779

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Revert "PB-296: Add failOnError to all layers" #779

merged 1 commit into from
Apr 11, 2024

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Apr 10, 2024 •
edited by github-actions bot
Loading

Reverts #768 due to mapfish print bug mapfish/mapfish-print#3255

Test link

@ltshb ltshb requested review from pakb and hansmannj April 10, 2024 17:23
@cypress Cypress
Copy link

cypress bot commented Apr 10, 2024

Passing run #1662 ↗︎

0 157 22 0 Flakiness 0

Details:

Revert "PB-296: Add failOnError to all layers"
Project: web-mapviewer Commit: fc915dea9b
Status: Passed Duration: 04:38 💡
Started: Apr 10, 2024 5:27 PM Ended: Apr 10, 2024 5:32 PM

Review all test suite changes for PR #779 ↗︎

hansmannj
hansmannj approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@hansmannj hansmannj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Probably we can re-think this and in mid-term find a nice way to inform the user, if one of multiple layers is not printed.

@ltshb ltshb merged commit 1436abd into develop Apr 11, 2024
6 checks passed
@ltshb ltshb deleted the revert-768-feat-PB-296-print-flag branch April 11, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansmannj hansmannj hansmannj approved these changes

@pakb pakb Awaiting requested review from pakb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltshb @hansmannj