Feedback #1
Feedback #1
Conversation
| band6 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b06.tiff") | ||
| band7 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b07.tiff") | ||
| band8 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b08.tiff") | ||
| band9 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b09.tiff") |
There was a problem hiding this comment.
Why do you read in the bands more than once? Is there a difference between these two sets of images?
There was a problem hiding this comment.
I understand remote sensing and the difference between bands. You read in band1 as
band1 <- ("b01.tiff")
and then overwrite it with
band1 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b01.tiff")
There is no reason to read them in twice (the second one overwrites the first).
index.Rmd
Outdated
|
|
||
| # Materials and methods | ||
|
|
||
| [~ 200 words] | ||
| I choosed 9 sites as training sites (Si polar swath"I00831006"; Lyot crater"V00823007"; Cerberus fossae"V00825005";Echus chasma"I00839002"; Sinus Meridiana west"I00849005"; Syrtis Major"I00853002"; Ophir planum"I00864002"; Marte vallis"I00868006; Eastern Meridiani"I00836002"). | ||
| For each training site, I downloaded and used Raster data. Those Raster data are Visible and infrared data in the “.TIFF” format and are combination of nine(9) or ten (10) bands according to Mars Odysee website. Each band is reflecting data in a specific wavelength. Even though all bands in each training site were already together in a single image in the website, I still re-added them together after using an image processing algorithm to correct the images in order to create a metadata file containing all information from each site. For Mars, I don't need to resize any band before adding them together because they all have the same size.I finally used the band ratio combination to determine the presence, abundance and distribution of water, water ice, ice or volatiles materials in each site I choosed as training site and from there I was able to see Lyot crater"V00823007" can be selected as the best future landing/mining site. I finally get the GPS coordinates of some locations within the Lyot crater"V00823007" site and plot those locations on a Martian globe using the package threejs.The locations shown on the Martian gloge which are within Lyot crater"V00823007" site are consider to be the future mining site because volatile materials are abundants in those locations compare to other location within Lyot crater"V00823007". |
There was a problem hiding this comment.
This is not explained adequately. The methods you use need to contained in this script (ideally) or explained with sufficient detail to reproduce the steps. The line "still re-added them together after using an image processing algorithm to correct the images in order to create a metadata file containing all information from each site" is nonsensical. Please revise/clarify.
|
|
||
| Code: The code associated with the project is well organized and easy to follow. Demonstrates mastery of R graphics and functions. | ||
| The goal here is to detect the site where we could have more water/ water ice/ volatiles materials. I applied some corrections to the satelitte images I downloaded. |
There was a problem hiding this comment.
what corrections? Why?
| * The first most important thing | ||
| * The second most important thing | ||
| * The third most important thing | ||
| I prepare the data by reading in the different bands that comprise the satelitte imagery. Each band refers to different spectrum and all bands below are from Lyot crater"V00823007" image. |
There was a problem hiding this comment.
please add a reference or URL pointing to this dataset.
index.Rmd
Outdated
| However, we are dealing with the Martian data in our project and we observed that for Martian data, we have the same size so we will just add them all together.But I add only band4, band5, band6, band8 and band9 together because those wavelength are able to reflect the distribution of water on the selected site. | ||
| ```{r} | ||
| #image1 <- stack(band4, band5, band6) | ||
| image2 <- stack(band4, band5, band6, band8, band9) #Here is for Mars images |
There was a problem hiding this comment.
There is only mars now, right? So you can revise language to remove mention of earth.
index.Rmd
Outdated
| #For Mars | ||
| nlayers(image2) #This give the number of bands use | ||
| crs(image2) #the coordinate system the imagery is projected in, and the resolution (or grid cell size) of the raster. | ||
| res #resolution of the images |
There was a problem hiding this comment.
check res, I don't think it's doing what you think it is here.
index.Rmd
Outdated
| For Mars,the formula change little bit because all bands are collected and stored in the same file in Mars Odysee website. False color or black and white could reveal the distribution of water. However, we use the formula: | ||
|
|
||
| MNDWI <- (band4)/(1/band9). | ||
| This formula is derived after multiple simulations and observations |
There was a problem hiding this comment.
what do you mean by 'multiple simulations and observations'? Please specify and preferably include the code here.
index.Rmd
Outdated
|
|
||
| ## PART2: Visualization of mining sites within the selected landing site on Martian gloge (map) | ||
|
|
||
| After knowing that Lyot crater"V00823007" site is the best site to be consider as best future landing site according to the figure above, We just get the GPS coordinates of some locations within the Lyot crater"V00823007" site (GPS coordinates from the onboard GPS of the spacecraft), created an exel file containing the coordinates of those locations and plot them on Martian georeferenced globe using the threejs package. |
There was a problem hiding this comment.
How do you know it's the 'best'? Not from this analysis. So this is more of an introduction than a result. Please revise.
index.Rmd
Outdated
| ## PART2: Visualization of mining sites within the selected landing site on Martian gloge (map) | ||
|
|
||
| After knowing that Lyot crater"V00823007" site is the best site to be consider as best future landing site according to the figure above, We just get the GPS coordinates of some locations within the Lyot crater"V00823007" site (GPS coordinates from the onboard GPS of the spacecraft), created an exel file containing the coordinates of those locations and plot them on Martian georeferenced globe using the threejs package. | ||
| As state previously, the locations within Lyot crater"V00823007" shown on the Martian gloge are the future mining site because volatile materials are more abundants in those locations compare to other location within Lyot crater"V00823007". |
There was a problem hiding this comment.
So this is apriori knowledge not a result - please revise to make this clear. The way it's written now makes it sound like this is a result.
index.Rmd
Outdated
| ``` | ||
|
|
||
| ##Results2 | ||
| I firstly prepared and loaded the data and then with the package called "threejs" I plot the exact locations of mining sites on the Martian global map. I created a cvs file where I stored the latitudes and logitude of the future mining sites within Lyot crater"V00823007" site and then call that file in R. |
There was a problem hiding this comment.
What was the preparation? No preparation here, just reading in a csv.
index.Rmd
Outdated
| # Conclusions | ||
| The selection of the best landing site is firstly done by choosing training sites and processing satellites images to see where the water or volatiles materials are abundant. Secondly, we get the geographical coordinates of the locations consider to be best mining sites within Lyot crater"V00823007" and plot them on a Martian globe using the package threej. |
There was a problem hiding this comment.
But this was not done in this script! You loaded and plotted some images (and a related index) and then loaded and plotted some points. There was no analysis.
| low = "#087F28", | ||
| name = "Water or Water ice or Volatiles materials") | ||
| ``` | ||
|
|
There was a problem hiding this comment.
So here is where I would expect you to take the index and somehow select locations from it (e.g. selecting the top 10 pixels or something). But instead, you just read in an unrelated set of points and plot it on a different image. There is no explicit connection between part 1 and part 2. You need to make that connection explicit (with code) for this project to be acceptable.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mastersince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mastersince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.master. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @hsare