remove unnecessary code #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grzegorz Filo <[email protected]>
|
@0xC0ncord , @perfinion ;) |
0xC0ncord
reviewed
Apr 28, 2024
| ifdef(`distro_gentoo',` | ||
| # Fix bug #537652 - grub2-mkconfig has search rights needed on current dir (usually user home dir) | ||
| userdom_search_user_home_dirs(bootloader_t) | ||
| ') |
There was a problem hiding this comment.
Does grub-mkconfig -o /boot/grub/grub.cfg continue to work after this is removed? I don't use grub anymore so I can't readily test this.
There was a problem hiding this comment.
Nevermind, I see you pointed this out in your original comment. :)
0xC0ncord
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding grub-mkconfig, this is no longer the case. There is dontaudit statement and config gets generated even without permisions for cwd.
Regarding portage, there is dac_read_search added to portage_t via if:
hardened-refpolicy/policy/modules/admin/portage.if
Line 75 in 9a23843