fix: add context manager and finalizer to JsonlLogger#30
Open
haosenwang1018 wants to merge 1 commit intogensyn-ai:mainfrom
Open
fix: add context manager and finalizer to JsonlLogger#30haosenwang1018 wants to merge 1 commit intogensyn-ai:mainfrom
haosenwang1018 wants to merge 1 commit intogensyn-ai:mainfrom
Conversation
JsonlLogger opens a file handle in __init__ but has no __del__ or context manager protocol, so the handle leaks if close() is not explicitly called (e.g., on exception). Add __enter__/__exit__ for use as context manager and __del__ as safety net for garbage collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JsonlLoggeropens a file handle in__init__but relies on explicitclose()calls. If an exception occurs beforeclose()is called, the file descriptor leaks and buffered data may be lost.Fix
Add
__enter__/__exit__methods soJsonlLoggercan be used as a context manager (with JsonlLogger(...) as logger:), and a__del__finalizer as a safety net during garbage collection.This is backward-compatible — existing code that calls
close()directly continues to work.