Skip to content

HW7#6

Open
zhehe0408 wants to merge 4 commits into
masterfrom
zhehe
Open

HW7#6
zhehe0408 wants to merge 4 commits into
masterfrom
zhehe

Conversation

@zhehe0408
Copy link
Copy Markdown
Collaborator

No description provided.

@gengho
Copy link
Copy Markdown
Owner

gengho commented Dec 1, 2016

everything goods super good
not need to change
i don't know what else i should write
but we have to write 5 comments
so here we go: the 5th line!

@gengho
Copy link
Copy Markdown
Owner

gengho commented Dec 1, 2016

Hw 7 writen by Zhe He:
Background

Describe what the application does
This script load the car2go raw data and map data and count the records by depart and destination.
Describe the role of the code being reviewed
Road the raw file and produce the core data.
Comment on

Choice of variable and function names
Easy to read.

Readability of the code
Good.

How improve reuse and efficiency

How use existing python packages
pandas
matplotlib
numpy

@Jason64178
Copy link
Copy Markdown
Collaborator

The homework is very good, and I don't think anything is needed to change
Background: This program combine the car2go OD data and map date together

Choice of variable and function names: Easy to read and understandable

Readability of the code: good

Easy to reuse but it seems it is not finished.
python packages: pandas matplotlib numpy

@xycyx
Copy link
Copy Markdown
Collaborator

xycyx commented Dec 15, 2016

Using the python to process the data in ArcGIS environment.
Readability is good and comments are really helpful.
Package usage: pandas, matplotlib, numpy
Minor suggestion: It could be better to use the relative path instead of the absolute path in order to enhance the transportability of programs.
And I suppose that we need to solve the conflicts before merge the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants