Skip to content

start over hw7#5

Open
gengho wants to merge 2 commits into
masterfrom
geng
Open

start over hw7#5
gengho wants to merge 2 commits into
masterfrom
geng

Conversation

@gengho
Copy link
Copy Markdown
Owner

@gengho gengho commented Dec 1, 2016

No description provided.

@zhehe0408
Copy link
Copy Markdown
Collaborator

A good beginning of the project.
Effective for downloading the data.
Choice of variable and function names: Easy to read.
Readability of the code: Good.
Convenient to reuse.

@Jason64178
Copy link
Copy Markdown
Collaborator

This file combined the codes from the beginning of the class, it is used many methods and packages we learned this quarter.

The choice of Choice of variable and function names is good.
Codes are readable with comments.
The improvement may not be needed.
existing python packages: requests, os, zipfile, pandas, numpy, matplotlib.pyplot

@xycyx
Copy link
Copy Markdown
Collaborator

xycyx commented Dec 15, 2016

This script is easy to read and the structure of this script is easy to follow.
Using request package to download the data and then numpy, pandas to clean the data.
The setup of the data acquiring and processing.
Exception test has been considered in functions.
Reusability can be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants