fix: always populate mot.usage in HuggingFace backend#697
Merged
jakelorocco merged 1 commit intogenerative-computing:mainfrom Mar 18, 2026
Merged
fix: always populate mot.usage in HuggingFace backend#697jakelorocco merged 1 commit intogenerative-computing:mainfrom
jakelorocco merged 1 commit intogenerative-computing:mainfrom
Conversation
…puting#694) Token count extraction in _post_process_async was gated behind `span is not None or metrics_enabled`, so mot.usage was never populated in plain (non-telemetry) runs. Now extracted unconditionally — usage is a standard mot field, not a telemetry concern.
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Contributor
Author
|
@jakelorocco this is the hf only test. |
jakelorocco
approved these changes
Mar 18, 2026
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
planetf1
changed the title
Merged
via the queue into
generative-computing:main
with commit Mar 18, 2026
4d3fc1b
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Description
Fixes #694
Token count extraction in
_post_process_asyncwas gated behindspan is not None or metrics_enabled, somot.usagewas alwaysNonein plain (non-telemetry) runs. Extraction is now unconditional — usage is a standard mot field, not a telemetry concern.Testing