Repository navigation
fix(subagent): honor configured and requested step budgets - #616
Merged
Merged
Conversation
|
[REVIEW NOTIFIER] This PR requires a review from @zhujian7. Once this PR has been reviewed and has the |
7 tasks done
Contributor
|
/lgtm |
Signed-off-by: Meng Yan <yanmxa@gmail.com>
san-ci
Bot
force-pushed
the
fix/subagent-step-budget
branch
from
October 11, 2026 16:01
aa3371e to
f2cb325
Compare
⛔ Auto-merge failedSan-CI attempted to auto-merge this PR but the merge was rejected by GitHub. Reason: 2 of 2 required status checks are in progress. - https://docs.github.com/articles/about-protected-branches Common causes:
Once the issue is resolved, San-CI will retry on the next relevant event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Agent(max_steps=1)currently runs with at least 500 inference steps. The executor treats 500 as a minimum and only lets the request increase the definition's budget, so short delegated tasks cannot enforce their requested limit.Honor positive agent-definition budgets and let a positive request override them, including smaller values. Use 500 only when no positive budget is provided. Update the tool schema and authoring guide to match. This is independent of the reporting and display fixes in #614.
Type of change
Testing
The checks include formatting, full build, vet, lint, layer checks, and the full unit/integration suite with the race detector. Configuration regressions cover smaller request and definition budgets. A real runtime regression proves
MaxSteps=1performs exactly one inference.Checklist
upstream/main