-
Notifications
You must be signed in to change notification settings - Fork 1
[BUG] Fix condition number computation and optional plotting #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Leguark
wants to merge
14
commits into
main
Choose a base branch
from
changes_for_server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `_compute_conditional_number` to return the computed condition number and made plotting optional with a new `plot` argument. Adjusted kernel options to store condition number during numpy backend operations.
Introduced a `use_gpu` parameter to enable GPU acceleration in the `pykeops_torch_cg` function. Adjusted solver backend logic to toggle between CPU and GPU based on this parameter.
Enhanced the `ConjugateGradientSolver` function with
Replaced helper function-based preconditioning with the adaptive Nyström preconditioner in the PyKeOps solver. This includes configurable strategies for pivot selection (`aggressive`, `conservative`, `minimal`) and fallback handling for robust kernel matrix approximation. Removed unused diagonal and Jacobi preconditioners. Cleaned up redundant code.
Introduced a `verbose` parameter to control diagnostic print statements during the iteration process.
Introduced a `clear_cache` method in the `WeightCache` class for better memory management. Enhanced the numerical stability of the conjugate gradient solver with improved initialization and adaptive tolerances. Refactored interpolation logic to handle weights more efficiently, and adjusted benchmarking to test expanded solver configurations.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] Fix condition number computation and optional plotting
Updated
_compute_conditional_number
to return the computed condition number and made plotting optional with a newplot
argument. Adjusted kernel options to store condition number during numpy backend operations.[BUG] Store condition number in kernel options during PyTorch backend operations
[CLN] Adjust import placement for conditional eigenvalue plotting
[TEST] More benchmarks
[ENH] Add GPU support for PyKeOps solver in torch backend
Introduced a
use_gpu
parameter to enable GPU acceleration in thepykeops_torch_cg
function. Adjusted solver backend logic to toggle between CPU and GPU based on this parameter.[ENH] Refactor and optimize PyKeOps Conjugate Gradient solver
Enhanced the
ConjugateGradientSolver
function with[WIP] Trying to add preconditioners to pykeops
[CLN/WIP] Try to add preconditioners
[ENH] Introduce Adaptive Nyström Preconditioner
Replaced helper function-based preconditioning with the adaptive Nyström preconditioner in the PyKeOps solver. This includes configurable strategies for pivot selection (
aggressive
,conservative
,minimal
) and fallback handling for robust kernel matrix approximation. Removed unused diagonal and Jacobi preconditioners. Cleaned up redundant code.[ENH] Add verbose option to Conjugate Gradient Solver
Introduced a
verbose
parameter to control diagnostic print statements during the iteration process.[CLN] Removed unused funtions
[CLN] Disable unused preconditioner logic in PyKeOps solver
[CLN] Add note on GPU incompatibility for unused preconditioner logic
Add caching improvements and enhance solver stability
Introduced a
clear_cache
method in theWeightCache
class for better memory management. Enhanced the numerical stability of the conjugate gradient solver with improved initialization and adaptive tolerances. Refactored interpolation logic to handle weights more efficiently, and adjusted benchmarking to test expanded solver configurations.