Skip to content

Provide a 'New ALE Project' wizard#108

Merged
echebbi merged 1 commit into
masterfrom
98-provide-new-ale-project-wizard
May 2, 2020
Merged

Provide a 'New ALE Project' wizard#108
echebbi merged 1 commit into
masterfrom
98-provide-new-ale-project-wizard

Conversation

@echebbi
Copy link
Copy Markdown
Collaborator

@echebbi echebbi commented Feb 26, 2020

Overview

Should close #98.

Provide a wizard that allows to create an ALE project with:

  • either an existing or a new Ecore model
  • a .ale file containing only behavior <name>;
  • a .dsl file linking the .ecore and the .ale files
  • (optional) a Sirius representation of the Ecore model
  • (optional) the Java nature

Demo

ale-wizard

@echebbi echebbi self-assigned this Feb 26, 2020
@echebbi
Copy link
Copy Markdown
Collaborator Author

echebbi commented Feb 28, 2020

I finally managed to create a Sirius representation in the new projects! To be honest this was waaaay too cumbersome.

Next I'll clean the code so that it can be reviewed while I'll write the tests.

@echebbi echebbi force-pushed the 98-provide-new-ale-project-wizard branch from 298c6c3 to c60a10a Compare February 29, 2020 23:31
@echebbi echebbi marked this pull request as ready for review February 29, 2020 23:47
@echebbi
Copy link
Copy Markdown
Collaborator Author

echebbi commented Feb 29, 2020

I think I'm almost done, the only remaining issue is that the new UI test does not pass on Jenkins (but succeeds locally).

For what I can see:

@dvojtise would you have any idea to solve the issue? Otherwise I'll drop the UI test and merely test the WorkspaceAleProject class which is actually responsible of creating the project: I don't want to spend hours investigating this.

@echebbi echebbi requested review from dvojtise and fcoulon February 29, 2020 23:56
@echebbi echebbi force-pushed the 98-provide-new-ale-project-wizard branch 2 times, most recently from a7c35c3 to ae05436 Compare March 2, 2020 23:03
@echebbi
Copy link
Copy Markdown
Collaborator Author

echebbi commented Mar 3, 2020

Sooo. Actually I get issues even when testing directly the back-end (exception thrown when trying to create a minifsm project):

org.eclipse.core.runtime.CoreException: Parent of resource: /minifsm is marked as read-only.
	at org.eclipse.emf.ecoretools.ale.ide.helloworld.tests.WorkspaceAleProjectTest.testCreateNewStandaloneProject(WorkspaceAleProjectTest.java:75)
Caused by: java.nio.file.AccessDeniedException: /minifsm
	at org.eclipse.emf.ecoretools.ale.ide.helloworld.tests.WorkspaceAleProjectTest.testCreateNewStandaloneProject(WorkspaceAleProjectTest.java:75)

I already faced a similar exception in a personal project and did not managed to overcome it yet. Even if the workspace is marked as read-only UI tests are able to create new projects so there must be a way to fix this but to be honest I'm fed up with fighting Eclipse all the time.

@dvojtise would you, by any chance, know how to solve this? Otherwise I would suggest to merely discard the tests: we may lost way more time making them work instead of manually testing the wizard when we modify it.

@dvojtise
Copy link
Copy Markdown
Contributor

dvojtise commented Mar 3, 2020

no, sorry, I never have seen this msg in other test projects

@echebbi echebbi force-pushed the 98-provide-new-ale-project-wizard branch from 22647cf to fe9ae3f Compare March 4, 2020 19:43
@echebbi
Copy link
Copy Markdown
Collaborator Author

echebbi commented Mar 4, 2020

@dvojtise I ended up dropping the tests. Apart from that the code is ready for a review.

echebbi added a commit that referenced this pull request Mar 4, 2020
Because:
 - makes easier to make an "ALE-aware" project (fix #98)

Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
@echebbi echebbi force-pushed the 98-provide-new-ale-project-wizard branch from fe9ae3f to c92cd4f Compare March 4, 2020 20:33
echebbi added a commit that referenced this pull request Mar 10, 2020
Because:
 - makes easier to make an "ALE-aware" project (fix #98)

Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
@echebbi echebbi force-pushed the 98-provide-new-ale-project-wizard branch from c92cd4f to 2b400b4 Compare March 10, 2020 17:02
@echebbi
Copy link
Copy Markdown
Collaborator Author

echebbi commented Apr 7, 2020

@dvojtise any news on this? PR #116 and #117 are also ready to be merged. If you don't have the time for a code review, can I take the liberty to merge them?

@dvojtise
Copy link
Copy Markdown
Contributor

dvojtise commented Apr 9, 2020

yes, if the CI compiles and meaningful tests are OK (I agree to not spend too much time on UI tests and comment them if this makes sense) then go ;-)

@echebbi echebbi force-pushed the 98-provide-new-ale-project-wizard branch from 2b400b4 to 23a4406 Compare May 1, 2020 23:58
@echebbi echebbi force-pushed the 98-provide-new-ale-project-wizard branch from 23a4406 to 5896169 Compare May 2, 2020 00:05
@echebbi echebbi merged commit 9535dab into master May 2, 2020
@echebbi echebbi deleted the 98-provide-new-ale-project-wizard branch May 2, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a "New ALE Project" wizard

2 participants