[codex] reduce SonarCloud maintainability findings#25
Merged
Conversation
Assisted-by: Codex:gpt-5.5
Assisted-by: Codex:gpt-5.5
Assisted-by: Codex:gpt-5.5
Assisted-by: Codex:gpt-5.5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Reduce the four open SonarCloud maintainability findings tracked in #24 without changing query parsing, query resolution, REPL behavior, or SQLite schema metadata output.
Closes #24
Scope
query-resolverexpression resolution into narrower compare, null comparison, and membership helpers.SQLiteCatalogFieldRow::newpositional constructor with purpose-specificimplicit_id,scalar, andlinkconstructors.Spec and plan alignment
List the
spec/andplan/files checked for this change. If the changeintentionally diverges from them, explain why and include the required document
update in this pull request.
spec/query.md: filter expression precedence, null comparison behavior, boolean filters, membership filters, and arithmetic operands are preserved.spec/storage-sqlite.md:_engine_catalog_fieldsmetadata shape and stored values are preserved.plan/query-expression-model-plan.md: expression model responsibilities remain in parser/resolver layers.plan/query-parser-implementation-plan.md: parser precedence test coverage is preserved.plan/sqlite-schema-plan-implementation-plan.md: deterministic catalog field row planning and metadata insert contracts are preserved.plan/cli-and-tooling-plan.md: REPL behavior remains tooling orchestration and does not add new engine behavior.Tests
List the automated and manual checks performed.
cargo test --workspacecargo fmt --checkcargo test -p query-parser parser_preserves_boolean_precedence_with_arithmeticcargo test -p query-resolvercargo test -p replcargo test -p sqlite-schema-planReview notes
Call out API boundaries, temporary rules, migration concerns, or follow-up work
that reviewers should inspect closely.
AI assistance
Disclose AI tool usage according to
AI_POLICY.md.messages with
Assisted-bytrailers.Tools and models: