Keyboard (↑↓) support for type picker in DataExplorer view #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaclarke
reviewed
Apr 11, 2025
There was a problem hiding this comment.
Thanks @dotlouis, this is great. I've actually been wanting to get around to improving keyboard support across the UI (particularly making the data explorer more spreadsheety), but other things have been higher priority so far.
We maybe have plans for a global 'command palette' kind of thing in the future, so might end up changing the keyboard shortcut at some point, but I think it's fine as it is for now.
|
Awesome, thanks for the review and kind words. A global command palette would be indeed very useful for navigating the UI swiftly. |
Co-authored-by: James Clarke <[email protected]>
- By default the up/down keys also seem to move the cursor to the end/start of the input, which I think is probably not useful here. - Just so it wraps around at the end. Co-authored-by: James Clarke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Gel team,
This is an attempt at fixing one of my biggest pet peeves using the Data Explorer (which I use a lot):
Support for keyboard events to enable selecting a type after searching for it in the dropdown without the mouse.
In addition, I've added listeners for the CMD+P/Ctrl+P shortcut (à la VSCode) to open this dropdown.
A few notes:
Let me know if that works for you. I would love to see this or a similar idea implemented in the UI.
Best