Extragradient and tests#21
Conversation
… added to this commit)
…be personal preference/against the code style, let me know i will drop them
… into extragradient_test # Conflicts: # .gitignore # fax/constrained/constrained_test.py # fax/test_util.py
gitignore cleanup
|
Can you open an issue with a brief explanation of what the bug is. It's not obvious to me from your link. Could you elaborate on what is preventing us from passing 2/20 tests? |
pierrelux
left a comment
pierrelux
left a comment
There was a problem hiding this comment.
Thanks for your work. General comment: this PR should really be split into smaller ones. Also, there seems to be a duplicate of code with #14. I also realized that #14 changes the CGA-related code to add type annotation and other auto-formatting changes: I would keep that separate as well and we should generally try to configure our IDEs so that we don't re-format everything on save.
|
non-extragradient changes
…o extragradient_test
|
@pierrelux Have all your requested changes been addressed? |
4 participants
(This pull request depends on the HS suite)
adds:
3 and 4 should be part of another PR, let me know if i should split this