-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable use of multiple shelly plugs #346
base: master
Are you sure you want to change the base?
Conversation
I just noticed this is basically a duplicate of the abandoned PR #232 addressing feautre request #118 😂 (plus changes to the dashboard, but using a single set of credentials for all plugs) |
My goal is to test this with multiple plugs, but even testing with one plug and seeing success would be good enough for me. |
How does this affect existing data? |
Good question that @DanForever! Details: I haven't actually deliberately tested that, but I've renamed jobs a couple times and got the old data showing up like that, so I'm confident it will happen as I've described. |
Good to know @SoongJr! :) Also, I wanted to mention it here as it's tangentially related, I bought myself one of the new Shelly Plus 1PM relays, but it has a new API vs the old ones, so I've updated @geerlingguy's script for polling the shelly, and created a pull request here: geerlingguy/shelly-plug-prometheus#6 |
I can tell you the data is kept in a prometheus database inside the prometheus docker container. I'm new to this stuff myself, so all I can advise is to google "prometheus change job name" or something. All data is linked to a job and you want to rename that from shelly-plug to whatever new name you are giving it. Hope it works out, please share your findings if you manage to do it ;) |
Any news on this one? |
Thought I'd poke my head in as we approach the anniversary of my last comment 😁. @geerlingguy I know you're a busy man, have you thought about appointing a moderator/collaborator/[insert-correct-nomclamenture-here] to act in your stead? |
This also includes some changes to the dashboard (to make the names of the plugs show up on the board), migrating the time series panel while doing so.
Please note the change from singular to plural in the variable names, which might make it harder to merge changes for others, but it felt to me like the right thing to do.