Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

review #3

wants to merge 1 commit into from

Conversation

santiweight
Copy link

Just a note:

this parser likely doesn't need a lexer. Looks like it is very expressable as a director parser combinator, which would be the common way to do this. Obviously, if you're following a book I understand

@gdevanla
Copy link
Owner

@santiweight Thanks a lot for the feedback. Those are very valuable comments and helps me learn how to write better parsers.

If you don't mind can I just pick and choose pieces of your PR and then commit it myself. I kind of want to maintain a theme for the blog and keep things closer to the book and therefore I have made some choices which my not entirely align with Haskell style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants