Use Organization's Canonical Name #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROR defines one name as the ror_display name - what they use as an organization's canonical name for the org's ROR page. Our script has been looking for that OR the first "label". Labels can be in other language, leading to the issue, for example, of a US university (University of Washington in St. Louis) being shown in Spanish in an English language Dataverse display.
As a first step towards a fix, this PR just looks only for the ror_display entry, which should always exist. As noted in #52, a more thorough fix could look for the label in the language used in the Dataverse display.