Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAL 185 - Added .clone() .equals() .hashCode() methods to hr-generator types #476

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

dev930018
Copy link
Contributor

While not likely necessary for production, this is required for testing to validate (a lack of) changes to records after applying Rules

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2019

CLA assistant check
All committers have signed the CLA.

@dev930018 dev930018 self-assigned this Oct 8, 2019
@dev930018 dev930018 changed the title Added .clone() .equals() .hashCode() methods to hr-generator types PAL 185 - Added .clone() .equals() .hashCode() methods to hr-generator types Oct 8, 2019
ac74475
ac74475 previously approved these changes Oct 9, 2019
Copy link
Member

@ac74475 ac74475 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks really good. I hadn't seen the use of @theory before, which is a cool feature

@ac74475 ac74475 self-requested a review October 9, 2019 09:58
@dev930018
Copy link
Contributor Author

Held back for a bit by a JUnit bug, be aware if using Theories in the future
junit-team/junit4#1629 (comment)

@nw1984 nw1984 requested a review from m09526 October 16, 2019 07:57
@m09526 m09526 merged commit 88a0685 into develop Oct 16, 2019
@m09526 m09526 deleted the PAL-185-Employee-object-functions branch October 16, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants