fix/ci-eslint-env-clean → master#109
Closed
shishir-21 wants to merge 4 commits intogbowne1:masterfrom
Closed
Conversation
Owner
|
Closing this PR because this work should be carried out post #117 PR merge and that PR should land soon. Ignore the CI runs till its merged and till we have completed the refactoring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done :-
Rebased cleanly on latest master
Resolved previous merge/rebase conflicts
Fixed server.js structure issues
Cleaned up package.json (resolved JSON parse error)
Regenerated and tracked package-lock.json for CI stability
Resolved all ESLint & Prettier errors
All tests passing locally
Result :-
npm run lint passes
npm test passes
No merge conflicts
CI should now run cleanly
No functional changes — cleanup and CI stabilization only.