Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run internal tests in Cygwin #1592

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Run internal tests in Cygwin #1592

merged 1 commit into from
Jan 17, 2025

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Jan 2, 2025

@Rangi42 Rangi42 added meta This isn't related to the tools directly: repo organization, maintainership... builds This affects the build process or release artifacts labels Jan 2, 2025
@Rangi42 Rangi42 added this to the 0.9.1 milestone Jan 2, 2025
@Rangi42 Rangi42 force-pushed the cygwin branch 3 times, most recently from cdb8761 to 6d5ed69 Compare January 2, 2025 19:04
@Rangi42
Copy link
Contributor Author

Rangi42 commented Jan 2, 2025

We probably don't need to test both 32- and 64-bit Cygwin, but I'm not sure which one we should pick.

@Rangi42 Rangi42 force-pushed the cygwin branch 2 times, most recently from a3272ad to f5c5f64 Compare January 2, 2025 19:22
@Rangi42
Copy link
Contributor Author

Rangi42 commented Jan 2, 2025

run-tests.sh: internal error

Hmm. I'm not sure verified Cygwin support is worth continuing to debug this.

@Rangi42 Rangi42 requested a review from ISSOtm January 2, 2025 19:49
@Rangi42 Rangi42 requested review from ISSOtm and removed request for ISSOtm January 3, 2025 03:56
@Rangi42 Rangi42 force-pushed the cygwin branch 2 times, most recently from 3f75c2e to 92aa8a9 Compare January 17, 2025 21:21
@Rangi42
Copy link
Contributor Author

Rangi42 commented Jan 17, 2025

Progress! RGBDS builds, and tests run up until it tries to build rgbgfx_test:

test/gfx/rgbgfx_test.cpp:311:9: error: 'siginfo_t' was not declared in this scope
  311 |         siginfo_t info;
      |         ^~~~~~~~~
test/gfx/rgbgfx_test.cpp:312:20: error: 'P_PID' was not declared in this scope
  312 |         if (waitid(P_PID, pid, &info, WEXITED) != 0) {
      |                    ^~~~~
test/gfx/rgbgfx_test.cpp:312:33: error: 'info' was not declared in this scope
  312 |         if (waitid(P_PID, pid, &info, WEXITED) != 0) {
      |                                 ^~~~
test/gfx/rgbgfx_test.cpp:312:39: error: 'WEXITED' was not declared in this scope; did you mean 'WIFEXITED'?
  312 |         if (waitid(P_PID, pid, &info, WEXITED) != 0) {
      |                                       ^~~~~~~
      |                                       WIFEXITED
test/gfx/rgbgfx_test.cpp:312:13: error: 'waitid' was not declared in this scope; did you mean 'waitpid'?
  312 |         if (waitid(P_PID, pid, &info, WEXITED) != 0) {
      |             ^~~~~~
      |             waitpid
test/gfx/rgbgfx_test.cpp:319:21: error: 'strsignal' was not declared in this scope; did you mean 'signal'?
  319 |                     strsignal(info.si_status),
      |                     ^~~~~~~~~
      |                     signal

Edit: Looks like Cygwin needs __POSIX_VISIBLE >= 199309.

Making sure _POXIC_C_SOURCE is defined fixed that, but there are still these left:

test/gfx/rgbgfx_test.cpp:318:20: error: 'P_PID' was not declared in this scope
  318 |         if (waitid(P_PID, pid, &info, WEXITED) != 0) {
      |                    ^~~~~
test/gfx/rgbgfx_test.cpp:318:39: error: 'WEXITED' was not declared in this scope; did you mean 'WIFEXITED'?
  318 |         if (waitid(P_PID, pid, &info, WEXITED) != 0) {
      |                                       ^~~~~~~
      |                                       WIFEXITED
test/gfx/rgbgfx_test.cpp:318:13: error: 'waitid' was not declared in this scope; did you mean 'waitpid'?
  318 |         if (waitid(P_PID, pid, &info, WEXITED) != 0) {
      |             ^~~~~~
      |             waitpid

Edit: Using waitpid avoids the need for siginfo_t and P_PID entirely.

@Rangi42 Rangi42 force-pushed the cygwin branch 7 times, most recently from 599cc71 to e056ab1 Compare January 17, 2025 23:15
@Rangi42 Rangi42 merged commit e561f63 into gbdev:master Jan 17, 2025
25 checks passed
@Rangi42 Rangi42 deleted the cygwin branch January 17, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds This affects the build process or release artifacts meta This isn't related to the tools directly: repo organization, maintainership...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants