Clarify clock terminology and speed#597
Merged
avivace merged 3 commits intogbdev:masterfrom May 11, 2025
Merged
Conversation
Currently there is some ambiguity about clock terminology and speed. This attempts to differentiate between a System Clock of ~1MHz and a Master Clock of ~4MHz (2x those in Double-speed mode). Alternatively "Oscillation Clock" could be used if that's preferable to "Master Clock"
avivace
reviewed
May 8, 2025
| ------|--------|-------------- | ||
| 1 | VDD | Power Supply +5V DC | ||
| 2 | PHI | System Clock | ||
| 2 | PHI | System Clock ≅ 1.05 MHz <br> (CGB Double-speed mode: ≅ 2.10 MHz) |
Member
There was a problem hiding this comment.
I could find only one other usage of ≅for "approx equivalent to" but many more ~. Maybe this should be clarified document wise as well?
Contributor
Author
There was a problem hiding this comment.
Right - I looked for examples of shortened MHz values and duplicated from that one instance. I think it is useful to indicate that it's an approximated value vs the full one in some way.
Contributor
Author
There was a problem hiding this comment.
Oh, to answer more directly "~" seems fine to me 👍
avivace
requested changes
May 11, 2025
avivace
approved these changes
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is some ambiguity about clock terminology and speed. This attempts to differentiate between a System Clock / PHI of ~1MHz and a Master Clock of ~4MHz (2x those in Double-speed mode).
Alternatively "Oscillation Clock" could be used if that's preferable to "Master Clock"
Testing the water with this approach, but open to other ideas