Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add behavior of the HDMA HBlank mode in halt mode #577

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Add behavior of the HDMA HBlank mode in halt mode #577

merged 2 commits into from
Nov 3, 2024

Conversation

alloncm
Copy link
Contributor

@alloncm alloncm commented Nov 1, 2024

No description provided.

ISSOtm
ISSOtm approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen this confirmed several times, so I'm approving this despite the lack of a reference. (Better have the information somewhere!)

Thank you!

@ISSOtm ISSOtm requested a review from avivace November 2, 2024 21:10
@alloncm
Copy link
Contributor Author

alloncm commented Nov 2, 2024

I can add a reference to a test ROM I wrote.
The issue with it is that it doesn't verify the transfer continues once the CPU is unhalted (that's why I didn't add it in this PR).
I verified this behavior manually with SameBoy though.

https://github.com/alloncm/MagenTests?tab=readme-ov-file#vram-dma-hblank-mode

avivace
avivace approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me in this state but I'd add the link to the test rom

avivace
avivace requested changes Nov 2, 2024
View reviewed changes
Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. like this

@alloncm alloncm requested a review from avivace November 3, 2024 22:26
@avivace avivace merged commit 01cdc20 into gbdev:master Nov 3, 2024
3 checks passed
@alloncm alloncm deleted the hdma-hblank-halt branch November 4, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivace avivace avivace approved these changes

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alloncm @avivace @ISSOtm