Fix saving world through GUI #3052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
arjo129
approved these changes
Sep 3, 2025
ahcorde
approved these changes
Sep 3, 2025
akky20
pushed a commit
to akky20/gz-sim
that referenced
this pull request
Sep 5, 2025
Similar to the changes in gazebosim/gz-gui#711. This was missed during the Qt5 -> Qt6 migration. The fileUrl var has changed to selectedFile Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]>
azeey
pushed a commit
that referenced
this pull request
Sep 5, 2025
* Fix comment for logical camera topic Updated topic name in comments for logical camera sensor. issue from #2252 Signed-off-by: Abhiroop <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> * [Bazel] Update bazel module to use jetty release branches (#3041) Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> * Remove obsolete tag from sdf (#3045) Signed-off-by: Nikodem Janik <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> * Update logic for setting initial state (#3044) Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> * Update theory_hydrodynamics.md with slight wording change (#3042) Signed-off-by: jmackay2 <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> * Fix saving world through GUI (#3052) Similar to the changes in gazebosim/gz-gui#711. This was missed during the Qt5 -> Qt6 migration. The fileUrl var has changed to selectedFile Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> * Update tutorial links (#3054) Signed-off-by: Carlos Agüero <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> * Add Null Check for Scene Initialization in `onRefreshCamerasImpl` to Prevent Crash (#3051) if scene is not initialized correctly, we should add a check and return directly. --------- Signed-off-by: momo <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> * correct the signoff Signed-off-by: Abhiroop Bhavsar <[email protected]> --------- Signed-off-by: Abhiroop <[email protected]> Signed-off-by: Abhiroop Bhavsar <[email protected]> Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Nikodem Janik <[email protected]> Signed-off-by: jmackay2 <[email protected]> Signed-off-by: Carlos Agüero <[email protected]> Signed-off-by: momo <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Nikodem <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: jmackay2 <[email protected]> Co-authored-by: Carlos Agüero <[email protected]> Co-authored-by: Oscmoar07 <[email protected]> Co-authored-by: Arjo Chakravarty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Similar to the changes in gazebosim/gz-gui#711. This was missed during the Qt5 -> Qt6 migration. The
fileUrlvar has changed toselectedFileTo test:
Run
gz sim -v 4with any world, go to the top left hand corner menu in the GUI and selectSave world(notSave world as..), select the world and save. Without this change, you'll see a QML warning complaining about the unknown varfileUrl.Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.