feat: Support custom toml path
#581
Conversation
| @@ -21,17 +20,7 @@ | |||
| TachSetupError, | |||
| TachVisibilityError, | |||
| ) | |||
| from tach.extension import ( | |||
There was a problem hiding this comment.
Avoiding direct imports for functions so we can directly mock without including the cli module in the path for the mocked function. When you import directly like this instead of mocking tach.extension.my_func you mock the cli module which can be a little bit awkward. The Google Python style guide additionally recommends this:
Use import statements for packages and modules only, not for individual types, classes, or functions.
Let me know if we're fine with this!
max-muoto
force-pushed
the
support-custom-toml-path
branch
from
2b2ba63 to
e2278f9
Compare
max-muoto
force-pushed
the
support-custom-toml-path
branch
from
9763b81 to
e26a23b
Compare
| def main() -> None: | ||
| args, parser = parse_arguments(sys.argv[1:]) | ||
| def main(argv: list[str] = sys.argv[1:]) -> None: | ||
| args, parser = parse_arguments(argv) | ||
| project_root = fs.find_project_config_root() or Path.cwd() |
There was a problem hiding this comment.
Given the use case in #579 , we also need to adjust the project_root which is passed to tach_server based on the location of the actual config file. This is needed for Tach to correctly interpret source_roots and differentiate between first-party and third-party imports.
I believe the config parsing code in Rust tracks the location of the config file, but it would be better for now to just adjust the usage of find_project_config_root in main to handle this specific LSP case.
| except Exception as e: | ||
| print(f"Failed to parse project config: {e}") | ||
| sys.exit(1) | ||
|
|
||
|
|
||
| def main() -> None: | ||
| args, parser = parse_arguments(sys.argv[1:]) | ||
| def main(argv: list[str] = sys.argv[1:]) -> None: |
There was a problem hiding this comment.
Not a huge deal because direct CLI usage is unlikely, but in this function there is a call to print_no_config_found which should now take the custom config argument so that the error message can be more accurate. Right now it will always say tach.toml is not found, even when specifying another name.
This PR adds support for custom
tach.tomlpaths for alltach serverfor usage in the VSCode plugin.