feat: stash kubernetes release #613

mateuszaaa · 2025-07-16T11:19:05Z

chore: gasp-1904: initial commit for node js upgrade
chore: gasp-1904: change config
chore: gasp-1904: fix linter and unused in gasp sdk mock
chore: gasp-1904: fix linter and unused in stash tests
chore: gasp-1904: fix linter and unused in stash util
chore: gasp-1904: fix linter and unused in stash services
chore: gasp-1904: fix linter and unused in stash scrapers
chore: gasp-1904: fix linter and unused in stash src/*
chore: gasp-1904: update package.json and yarn.lock
chore: gasp-1904: update test dependencies
chore: gasp-1904 update eslint and pretty-quick
chore: gasp-1904 move to one redis (not tests)
chore: gasp-1904 update types eslint
chore: gasp-1904 remove unused
chore: gasp-1904 function fix and remove second container from tests
chore: fix formatting and add redis-stash-test-data docker image config
chore: gasp-1904 remove timeseries and updates to tests
chore: update redis image in compose file to gaspxyz/redis-stash-test-data:stable
chore: gasp-1904 fix data or skip the tests with old data
chore: gasp-1904 fix prettier
chore: gasp-1904 fix timestamp transformation
chore: gasp-1904 add minutes for token refresh to compose
ci(fix): set moon cli to 1.34.0 version to be used within gha workflows
ci(stash): fix release job dependencies for stash
chore: gasp-2215: use one redis in app yaml files + add tokens to hardcode variable to compose yaml (chore: gasp-2215: use one redis in app yaml files + add tokens to hardcode variable to compose yaml #603)
chore: stash move non sensitive data out of sops files (chore: stash move non sensitive data out of sops files #604)
chore: pool rates repository hash tag fix (chore: pool rates repository hash tag fix #605)
chore: remove gasp-avs image dependencies on gasp-node binary (chore: remove gasp-avs image dependencies on gasp-node binary #602)
chore: chain and prices repository hash tag fix (chore: chain and prices repository hash tag fix #606)
bump submodule
feat: revert keys optimization (feat: revert keys optimization #611)
feat: GASP-2267 fix missing metrics on startup (feat: GASP-2267 fix missing metrics on startup #612)

…grade_node_version

…-data:stable

…grade_node_version

…GASP-1904/upgrade_node_version

…kflows

…+ cleanup

…dcode variable to compose yaml (#603) chore: gasp-2215: use one redis in app yaml files + add tokens to hardcode to compose yaml

chore: move non sensitive data out of sops files

* chore: chain and prices repository hash tag fix * chore: gasp-2244 make saving of events dependent on a variable * chore: gasp-2244 prod env of stash to save events

…develop-alignment

…ignment chore: post ferries release alignment

* revert keys changes * fetch logs in batches * chore: revert rates key optimisation Signed-off-by: Olga Konstantinov <[email protected]> * chrore: Fix race condition of finalized and current block. Add debug trace * feat: endpoint for garbage collection --------- Signed-off-by: Olga Konstantinov <[email protected]> Co-authored-by: Olga Konstantinov <[email protected]> Co-authored-by: Gonzalo DC <[email protected]>

* chore: fix missing metrics on startup * chrore: format with go fmnt and added github.com/btcsuite/btcd v0.22.0-beta to fix ambiguous import --------- Co-authored-by: mateuszaaa <[email protected]>

gemini-code-assist

Summary of Changes

Hello @mateuszaaa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a substantial infrastructure overhaul for the stash service. Key changes include upgrading the Node.js runtime, consolidating Redis instances for unified data management, and streamlining the gasp-avs Docker image by removing external binary dependencies. These updates aim to enhance performance, simplify deployment, and improve overall system maintainability.

Highlights

Node.js Upgrade: The project's Node.js runtime has been upgraded from version 18.20.7 to 22.14.0, accompanied by comprehensive dependency updates and linter fixes across the codebase.
Redis Consolidation: The application now utilizes a single Redis instance for all data storage, including timeseries data, replacing the previous setup that used separate Redis instances. This simplifies the architecture and configuration.
GASP AVS Docker Image Refactor: The gasp-avs Docker image has undergone a significant refactoring, removing its dependency on the gasp-node binary and the supervisor setup. The gasp-avs service now runs as a single, streamlined process within its container.
CI/CD Pipeline Simplification: The image building and pushing processes within the CI/CD pipeline have been simplified, reflecting the consolidated Redis setup and the refactored gasp-avs Docker image.
Data Management Improvement: A new endpoint has been introduced for garbage collecting old pool rates data, which helps in maintaining data hygiene and optimizing storage.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a significant set of changes, including a Node.js version upgrade, dependency cleanup, and architectural improvements like decoupling the gasp-avs service and consolidating Redis usage. These are all positive steps towards a more maintainable and streamlined system.

My main concern is the number of skipped tests across various files. While the moon.yml configuration re-enables the test command, many test suites and individual tests are still disabled within the test files themselves. It's critical to address this to ensure regressions are not introduced. I've left specific comments on each skipped test.

I also found a leftover console.log statement that should be removed. Otherwise, the code changes look consistent and well-aligned with the goals described in the commit messages.

gemini-code-assist · 2025-07-16T11:24:07Z

stash/test/api/deposit.tracing.api.test.ts

@@ -8,7 +9,7 @@ let transactionData: any
 const wrongType = 'deposittt'
 const type = 'deposit'

-describe('TracingController', () => {
+describe.skip('TracingController', () => {


This test suite is currently skipped. It's important to ensure all tests are active and passing to maintain code quality and prevent regressions. Please re-enable this suite or provide context on the plan to do so.

gemini-code-assist · 2025-07-16T11:24:07Z

stash/test/api/staking.api.test.ts


 function validateValidApyRange(body) {
  const apy = parseFloat(body.apy)
  expect(apy).to.be.lessThanOrEqual(300)
  expect(apy).to.be.greaterThan(100)
 }

-describe('APi tests: Collator apy - dailyRewards', () => {
+describe.skip('APi tests: Collator apy - dailyRewards', () => {


This entire test suite is skipped. To ensure the stability of the application, please re-enable these tests and confirm they pass before merging.

gemini-code-assist · 2025-07-16T11:24:07Z

stash/test/api/token.stats.api.test.ts

@@ -65,7 +66,7 @@ describe('APi tests: token stats', () => {
        expect(onlyGaspV2[0]).toEqual(gaspV2Token)
      })
  })
-  it('GET /token/list/stats - List matches with all the tokens with pool', async () => {
+  it.skip('GET /token/list/stats - List matches with all the tokens with pool', async () => { //to fix data on the frontend node


This test is skipped with a TODO comment. It's important to address this to ensure full test coverage. Could you please update the test or create a follow-up ticket to track this?

gemini-code-assist · 2025-07-16T11:24:07Z

stash/test/api/tvl.history.api.test.ts

 import { tokenIDs } from './utils'

 describe('/GET tvl-history', () => {
-  it('GET /tvl-history - Schema validation', async () => {
+  it.skip('GET /tvl-history - Schema validation', async () => {


This test is currently skipped. Please re-enable it to ensure the functionality is properly tested before merging.

gemini-code-assist · 2025-07-16T11:24:07Z

stash/test/coingecko.unit.test.ts


 vi.mock('gasp-sdk')

-describe('[CoinGecko listing]', () => {
+describe.skip('[CoinGecko listing]', () => {


This test suite has been skipped. It's crucial to have all tests running to catch any potential issues. Please re-enable this suite and ensure all tests pass.

gemini-code-assist · 2025-07-16T11:24:07Z

stash/test/l1.scraper.test.ts


-describe('L1LogScraper', () => {
+describe.skip('L1LogScraper', () => {


This entire test suite is skipped. Disabling tests can hide potential regressions. Please re-enable these tests or clarify the plan for their re-activation.

gemini-code-assist · 2025-07-16T11:24:08Z

stash/test/liquid.staking.unit.test.ts

+  it.skip('should mock the 24 hours rewards history endpoint', async () => {
+    //TODO: rewrite this test,data that we have in a db from last year so returning []
    const expectedResponse: ResponseRewards[] = [
      { liquidityTokenId: '8', amountClaimed: '503619012693557062128' },
    ]
    const results = await rewards24hours(
-      '5FFTemNzVqVduFk7n8z7G6qukrnBfTTQRE8EGPbjmtdpz2c1'
+      '0x928f1040adb982d3ab32a62dc8eda57e9b81b4dd',
    )
    expect(results).deep.equal(expectedResponse)
  })

-  it('should mock the month rewards history endpoint', async () => {
+  it.skip('should mock the month rewards history endpoint', async () => {


These tests are skipped with a TODO to be rewritten. To prevent a reduction in test coverage, please address this before merging or create a ticket to track the required updates.

gemini-code-assist · 2025-07-16T11:24:08Z

stash/test/prices.big_swap.integration.test.ts

 import Decimal from 'decimal.js'
 import IORedis from 'ioredis'
+import { GenericContainer, Wait } from 'testcontainers'
+import { afterAll, beforeAll, chai, describe, it, vi } from 'vitest'
 chai.should()

 describe.skip('Integration Test using Test Containers', function () {


This integration test suite is skipped. Please ensure these tests are active and passing to validate the end-to-end functionality.

gemini-code-assist · 2025-07-16T11:24:08Z

stash/test/tracing.test.ts


 vi.mock('../src/repository/TransactionRepository')
 vi.mock('../src/util/Logger')

-describe('TracingService', () => {
+describe.skip('TracingService', () => {


This test suite is skipped. Please re-enable it and ensure all tests pass to maintain test coverage.

gemini-code-assist · 2025-07-16T11:24:08Z

avs-aggregator/aggregator.go

@@ -210,12 +210,14 @@ func (agg *Aggregator) Start(ctx context.Context) error {
 	if agg.rpcServer != nil {
 		go agg.rpcServer.startServer(ctx, agg.apiKey, runTriggerC)
 	}
-
+
+	recordMetrics(agg.logger, agg.ethRpc)


Moving recordMetrics before the if agg.startIdle block ensures that metrics are recorded regardless of whether the aggregator is awaiting a run trigger. This ensures consistent metric reporting.

…yment feature: Disable automatic deployment on merge to main

mangatafinance · 2025-07-16T14:11:46Z

Run report for b407f898 `(build-docker-images, Build docker images, ubuntu-24.04, true, 5, moon :build-image-ci)`

Total time: 11m 1s | Comparison time: 33m 45s | Estimated savings: 22m 44s (67.4% faster)

	Action	Time	Status	Info
🟩	`SyncWorkspace`	368.2ms	Passed
⬛️	`SetupToolchain(system)`	0.2ms	Skipped
🟩	`SyncProject(system, sequencer)`	1.4ms	Passed
🟩	`SyncProject(system, gasp-avs)`	1.7ms	Passed
🟩	`SyncProject(system, contracts)`	1.3ms	Passed
🟩	`SyncProject(system, updater)`	2.8ms	Passed
🟩	`SyncProject(system, gasp-node)`	4.1ms	Passed
🟩	`SyncProject(system, avs-aggregator)`	0.5ms	Passed
🟩	`SetupToolchain(node:22.14.0)`	5.6s	Passed
🟩	`SetupToolchain(node:18.20.7)`	8.7s	Passed
🟩	`RunTask(contracts:buildkit-build-and-push-image-digests)`	21.3s	Passed
🟩	`RunTask(sequencer:buildkit-build-and-push-image-digests)`	3m 49s	Passed	SLOW
🟩	`RunTask(updater:buildkit-build-and-push-image-digests)`	4m 16s	Passed	SLOW
🟩	`RunTask(gasp-avs:buildkit-build-and-push-image-digests)`	5m 14s	Passed	SLOW
🟩	`SyncProject(node, stash)`	0.9ms	Passed
🟩	`SyncProject(node, ferry-deposit)`	0.5ms	Passed
🟩	`SyncProject(node, ferry-withdrawal)`	0.4ms	Passed
🟩	`RunTask(contracts:build-image-ci)`	9.5s	Passed
🟩	`RunTask(sequencer:build-image-ci)`	15.2s	Passed
🟩	`RunTask(updater:build-image-ci)`	12.8s	Passed
	And 12 more...

Expanded report

	Action	Time	Status	Info
🟩	`RunTask(gasp-avs:build-image-ci)`	12.9s	Passed
🟩	`RunTask(avs-aggregator:buildkit-build-and-push-image-digests)`	1m 44s	Passed
🟩	`RunTask(stash:buildkit-build-and-push-image-digests)`	1m 57s	Passed
🟩	`RunTask(ferry-deposit:buildkit-build-and-push-image-digests)`	2m 16s	Passed	SLOW
🟩	`RunTask(avs-aggregator:build-image-ci)`	15.2s	Passed
🟩	`RunTask(stash:build-image-ci)`	15.7s	Passed
🟩	`RunTask(ferry-deposit:build-image-ci)`	16.9s	Passed
🟩	`RunTask(gasp-node:buildkit-build-and-push-image-digests-fast-runtime)`	8m 58s	Passed	SLOW
🟩	`RunTask(ferry-withdrawal:buildkit-build-and-push-image-digests)`	1m 41s	Passed
🟩	`RunTask(ferry-withdrawal:build-image-ci)`	16.8s	Passed
🟩	`RunTask(gasp-node:buildkit-build-and-push-image-digests-standard-runtime)`	6m 47s	Passed	SLOW
🟩	`RunTask(gasp-node:build-image-ci)`	23.5s	Passed

Environment

OS: Linux
Matrix:

prefix = build-docker-images
name = Build docker images
runner = ubuntu-24.04
buildkit-enable = true
buildkit-replicas = 5
command = moon :build-image-ci

Variables:

MOON_COLOR = 2
MOON_DEBUG_PROTO_INSTALL = false
MOON_CACHE = off
MOON_VERSION = 1.34.0

Touched files

.github/workflows/deploy-stash.yml

olgakonsta and others added 30 commits April 7, 2025 15:07

chore: gasp-1904: initial commit for node js upgrade

08d161e

chore: gasp-1904: change config

767129b

chore: gasp-1904: fix linter and unused in gasp sdk mock

37e4d52

chore: gasp-1904: fix linter and unused in stash tests

328d3fc

chore: gasp-1904: fix linter and unused in stash util

9644cf7

chore: gasp-1904: fix linter and unused in stash services

6f23615

chore: gasp-1904: fix linter and unused in stash scrapers

71941e5

chore: gasp-1904: fix linter and unused in stash src/*

cdc8209

chore: gasp-1904: update package.json and yarn.lock

14f366c

chore: gasp-1904: update test dependencies

aaf3d5e

Merge remote-tracking branch 'origin/develop' into chore/GASP-1904/up…

34d2061

…grade_node_version

chore: gasp-1904 update eslint and pretty-quick

00bae7d

chore: gasp-1904 move to one redis (not tests)

c2ef2e7

chore: gasp-1904 update types eslint

e175fee

chore: gasp-1904 remove unused

ae0719e

chore: gasp-1904 function fix and remove second container from tests

67a3fdc

chore: fix formatting and add redis-stash-test-data docker image config

b723a92

chore: gasp-1904 remove timeseries and updates to tests

72af275

chore: update redis image in compose file to gaspxyz/redis-stash-test…

af305d4

…-data:stable

chore: gasp-1904 fix data or skip the tests with old data

44f8133

Merge remote-tracking branch 'origin/develop' into chore/GASP-1904/up…

cffaa0e

…grade_node_version

chore: gasp-1904 fix prettier

111d88f

Merge branch 'develop' of github.com:gasp-xyz/gasp-monorepo into chore/…

992a748

…GASP-1904/upgrade_node_version

Merge branch 'develop' into chore/GASP-1904/upgrade_node_version

7dc12d8

chore: gasp-1904 fix timestamp transformation

35d1e37

chore: gasp-1904 add minutes for token refresh to compose

badafc6

ci(fix): set moon cli to 1.34.0 version to be used within gha wor…

f4c2ab7

…kflows

ci(stash): fix release job dependencies for stash

45efe30

chore: stash cluster configuration + one redis + dependencies update …

2a51f60

…+ cleanup

chore: gasp-2215: use one redis in app yaml files + add tokens to har…

3140ea6

…dcode variable to compose yaml (#603) chore: gasp-2215: use one redis in app yaml files + add tokens to hardcode to compose yaml

olgakonsta and others added 10 commits June 2, 2025 13:14

chore: stash move non sensitive data out of sops files (#604)

d63b8a3

chore: move non sensitive data out of sops files

chore: pool rates repository hash tag fix (#605)

c79987f

chore: remove gasp-avs image dependencies on gasp-node binary (#602)

3266422

chore: chain and prices repository hash tag fix (#606)

aab1b9b

* chore: chain and prices repository hash tag fix * chore: gasp-2244 make saving of events dependent on a variable * chore: gasp-2244 prod env of stash to save events

Merge remote-tracking branch 'origin/main' into feature/post-ferries-…

8ee02a0

…develop-alignment

bump submodule

fd6ba85

Merge pull request #607 from gasp-xyz/feature/post-ferries-develop-al…

fd1d46a

…ignment chore: post ferries release alignment

Merge remote-tracking branch 'origin/main' into develop

71fbe91

feat: GASP-2267 fix missing metrics on startup (#612)

976eddd

* chore: fix missing metrics on startup * chrore: format with go fmnt and added github.com/btcsuite/btcd v0.22.0-beta to fix ambiguous import --------- Co-authored-by: mateuszaaa <[email protected]>

gemini-code-assist bot reviewed Jul 16, 2025

View reviewed changes

goncer and others added 2 commits July 16, 2025 15:55

Update deploy-stash.yml

c31d8fa

Merge pull request #614 from gasp-xyz/feature/disable-automatic-deplo…

b407f89

…yment feature: Disable automatic deployment on merge to main

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: stash kubernetes release #613

feat: stash kubernetes release #613

Uh oh!

mateuszaaa commented Jul 16, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

mangatafinance commented Jul 16, 2025

Uh oh!

Uh oh!


		describe('L1LogScraper', () => {
		describe.skip('L1LogScraper', () => {

feat: stash kubernetes release #613

Are you sure you want to change the base?

feat: stash kubernetes release #613

Uh oh!

Conversation

mateuszaaa commented Jul 16, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

mangatafinance commented Jul 16, 2025

Run report for b407f898 (build-docker-images, Build docker images, ubuntu-24.04, true, 5, moon :build-image-ci)

Uh oh!

Uh oh!

Run report for b407f898 `(build-docker-images, Build docker images, ubuntu-24.04, true, 5, moon :build-image-ci)`