Skip to content

feat: anti-skip rule for all review skills (v0.15.6.1)#804

Merged
garrytan merged 3 commits intomainfrom
garrytan/anti-skip-review-rule
Apr 5, 2026
Merged

feat: anti-skip rule for all review skills (v0.15.6.1)#804
garrytan merged 3 commits intomainfrom
garrytan/anti-skip-review-rule

Conversation

@garrytan
Copy link
Copy Markdown
Owner

@garrytan garrytan commented Apr 4, 2026

Summary

Review skills sometimes skip sections when reviewing strategy or spec plans, reasoning that "implementation sections don't apply to a strategy doc." This is wrong. Implementation details are where strategy breaks down.

Anti-skip rule added to all 4 review skills:

  • CEO review (sections 1-11): plan-ceo-review/SKILL.md.tmpl
  • Eng review (sections 1-4): plan-eng-review/SKILL.md.tmpl
  • Design review (passes 1-7): plan-design-review/SKILL.md.tmpl
  • DX review (passes 1-8): plan-devex-review/SKILL.md.tmpl

Also fixes: CEO review header from "10 sections" to "11 sections" (Section 11 is conditional but exists).

The rule is simple: evaluate every section. If zero findings, say "No issues found" and move on. But you must look.

Pre-Landing Review

No issues found. This is static prompt text in template files, no runtime code.

Test plan

  • bun test passes
  • bun run gen:skill-docs regenerates all SKILL.md files
  • Grep confirms anti-skip rule in all 8 files (4 templates + 4 generated)

🤖 Generated with Claude Code

garrytan and others added 2 commits April 4, 2026 16:51
Review skills sometimes skip sections when reviewing strategy or spec
plans. This adds an explicit anti-skip rule to CEO (1-11), eng (1-4),
design (1-7), and DX (1-8) review skills. Also fixes CEO header from
"10 sections" to "11 sections" to match actual count.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

E2E Evals: ✅ PASS

14/14 tests passed | $1.82 total cost | 12 parallel runners

Suite Result Status Cost
e2e-design 1/1 $0.1
e2e-plan 5/5 $0.83
llm-judge 3/3 $0.06
e2e-plan 5/5 $0.83

12x ubicloud-standard-2 (Docker: pre-baked toolchain + deps) | wall clock ≈ slowest suite

Main landed v0.15.6.1 (skill prefix self-healing). Bumped our entry
to v0.15.6.2 to sit on top.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@garrytan garrytan merged commit 31943b2 into main Apr 5, 2026
18 checks passed
joethorngren added a commit to joethorngren/jstack that referenced this pull request Apr 6, 2026
Upstream features merged:
- GStack Browser with anti-bot stealth (garrytan#695)
- Adaptive gating + cross-review dedup for review army (garrytan#760)
- Voice-friendly skill triggers for AquaVoice (garrytan#732)
- Native OpenClaw skills + ClaHub publishing (garrytan#832)
- Declarative multi-host platform (OpenCode, Slate, Cursor, OpenClaw) (garrytan#793)
- Interactive /plan-devex-review + DX review skills (garrytan#784, garrytan#796)
- Ship re-run verification checks (garrytan#833)
- Community security wave — 8 PRs, 4 contributors (garrytan#847)
- Security wave 1 — 14 fixes for audit (garrytan#810)
- Team-friendly gstack install mode (garrytan#809)
- Anti-skip rule for all review skills (garrytan#804)
- Various bug fixes and doc updates

Conflict resolution strategy:
- Branding files (README, CLAUDE.md, CHANGELOG, VERSION, CONTRIBUTING, TODOS): kept jstack
- SKILL.md / SKILL.md.tmpl files: took upstream (skill improvements)
- Code files (browse/, scripts/, tests, setup, package.json): took upstream
- Telemetry files (bin/gstack-telemetry-sync, supabase telemetry-ingest): kept deleted (jstack privacy policy)
- New upstream files (hosts/, openclaw/, devex-review/, etc.): accepted as-is

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant