Skip to content

fix: untrack binary, Docker chmod, os.tmpdir (#779, #709, #708)#799

Closed
itstimwhite wants to merge 4 commits intogarrytan:mainfrom
itstimwhite:itstimwhite/easy-win-issues
Closed

fix: untrack binary, Docker chmod, os.tmpdir (#779, #709, #708)#799
itstimwhite wants to merge 4 commits intogarrytan:mainfrom
itstimwhite:itstimwhite/easy-win-issues

Conversation

@itstimwhite
Copy link
Copy Markdown
Contributor

Summary

Three mechanical fixes from the open issue tracker:

Pre-Landing Review

No issues found.

Test plan

  • bun test passes (all tiers)
  • git ls-files bin/gstack-global-discover returns empty
  • grep -r 'B=~/' *.md unaffected (tilde fix deferred, see below)

Notes

🤖 Generated with Claude Code

itstimwhite and others added 4 commits April 3, 2026 22:23
58MB Mach-O arm64 binary was tracked despite being in .gitignore (line 5).
The .ts source file remains tracked for reproducible builds via ./setup.
Note: git rm --cached removes from the index only. Existing clones retain
the binary in git history until a future history rewrite.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chmod -R 1777 /tmp recursively sets the sticky bit on files inside /tmp,
which is meaningless (sticky bit only matters on directories). Line 61
already correctly sets /tmp itself. Replace with find -type d to only
chmod directories.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cookie-import-browser.ts hardcoded /tmp for temporary SQLite copies.
os.tmpdir() is the portable Node.js API and is already imported. On
macOS this resolves to a per-user temp directory (/var/folders/...),
which is actually a security improvement (mode 700 vs world-writable).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@garrytan
Copy link
Copy Markdown
Owner

garrytan commented Apr 5, 2026

Closing — Docker chmod and os.tmpdir overlap with open PRs #747 and #748. The binary untracking from #779 was already resolved (binaries are no longer tracked). Thank you @itstimwhite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants