Repository navigation
v1.91.139.0 fix(evals): docsync observer accepts read-only git describe - #3276
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
Contributor
E2E Evals: ✅ PASS13 executed, 0 reused rule/judge records | 0 manual accepted (unscored; no score-cache credit) | $20.77 rule/judge cost | reconcile exit: 0 Profile: pr / mode Rule and judge shards
Fail-closed reconciliationSliced lane: planner → duration-packed executors → fail-closed report. Behavior cases run a pre-registered 3-trial panel (PASS at 2/3 with no contract violation); a PASS 2/3 is shown with its failed trial, never as a clean pass. Reused results retain their original provenance and expiry. |
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paid rule case
ship-docsync-storewent red on #3272 (run 39153452209, head a844821) for a reason that PR didn't cause. The /document-release child agent rangit describe --tags --always. That command is read-only, but it wasn't in the fixture's declared docs observation interface, so the observer failed the case with "command outside declared docs observation interface". GStack Minder's call (2026-10-18): it's a legitimate read, so this PR adds it to the interface. The child prompt is not steered away from it.Change
Observer.
test/helpers/docsync-observer.tsgainsDOCS_DESCRIBE_FLAGSand adescribebranch in the literal-command check. The observer prose in the docs interface now lists the same rule.git describeform--tags,--always,--abbrev=<digits>,--exact-match, in any combination, with at most one revision--dirty,--brokenindex.lockand rewrite.git/index--contains,--all, a bare or non-numeric--abbrev, two revisions,-- HEADTests.
test/docsync-command-grammar.test.tsadds:.git/indexchange;git tag v9 HEAD,git update-index --refresh,git notes add -m x HEAD,--dirty, redirection (> tag.md) and composition (; git tag v9);--dirtyreally does write the index.Without the observer change, the capture test and the read-only-forms test both fail.
Gate-integrity edits
test/helpers/docsync-observer.ts: read-onlygit describeadded to the docs observation interface (code allowlist and prose)No threshold, assertion, trial count, case kind or prompt instruction changes.
Checks
ship-docsync-storepassed 1/1 for $3.83. The child rangit describe --tags --alwaystwice and the observer accepted both. It ran throughtest-paid-shards.ts --tier gate --case ship-docsync-storewith the CI-pinned bun, node and Claude CLI 2.1.292.bun run typecheckis clean andtypecheck:testreports no new diagnostics.docsync-spawnedplus the 12ship-docsync-*cases, and no judges.