Repository navigation
v1.91.120.0 test: split the doctor windows bash test so each case fits the Windows per-test timeout - #3241
Merged
Conversation
…s per-test timeout Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
Contributor
E2E Evals: ✅ PASS0 executed, 0 reused rule/judge records | 0 manual accepted (unscored; no score-cache credit) | $0 rule/judge cost | reconcile exit: 0 Profile: pr / mode Rule and judge shards
Fail-closed reconciliationSliced lane: planner → duration-packed executors → fail-closed report. Behavior cases run a pre-registered 3-trial panel (PASS at 2/3 with no contract violation); a PASS 2/3 is shown with its failed trial, never as a clean pass. Reused results retain their original provenance and expiry. |
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
windows bashdoctor test from #3236 timed out on Windows (run 39003503231, shard 5) because the test is too slow, not because something hangs. It ran five fullbin/gstack-doctorpasses in a single test. Each pass takes up to about 6 s on a Windows runner, so the test's wall time across the last six Windows runs was 20.5, 21.5, 28.2, 28.6, 30.0 (a pass) and 30.0 s (the timeout).The
EBUSYcleanup error is fallout from the timeout. When a test times out, Bun 1.4.2 SIGTERMs thespawnSyncbash child it is blocked on, but the doctor's own children (thebun/gitsubprocesses, with their cwd in the fixture) survive. On Windows those survivors lock the fixture directory, soafterEach'srmSyncfails. This reproduces locally withbun test --timeout=2000on a spawnSync child that forks a grandchild: Bun reports "killed 1 dangling process", the test fails at about 2000 ms, and the grandchild keeps running to completion.This PR splits the test into three tests, one per case, each with its own fixture and at most two doctor passes:
git --exec-path,GSTACK_GIT_BASH)GSTACK_GIT_BASHand a differentGSTACK_BASHwarn, naming bothBASH_UNAVAILABLErefusal, and no row off WindowsEvery assertion is unchanged: 13
expectcalls before and after. No timeout was raised.Checks:
bun test test/gstack-doctor.test.ts(51 pass), the spawnSync-timeout tripwire, the module-size ratchet andtypecheck:test. Repeated windows-free-tests runs on this branch are linked in the comments.