Repository navigation
v1.91.123.0 fix(cso): comprehensive verify can patch read-only snapshots and accepts runtime-plan's profile - #3240
Merged
Merged
Conversation
…pts runtime-plan's profile
|
😎 This pull request was merged. |
Contributor
E2E Evals: ✅ PASS0 executed, 0 reused rule/judge records | 0 manual accepted (unscored; no score-cache credit) | $0 rule/judge cost | reconcile exit: 0 Profile: pr / mode Rule and judge shards
Fail-closed reconciliationSliced lane: planner → duration-packed executors → fail-closed report. Behavior cases run a pre-registered 3-trial panel (PASS at 2/3 with no contract violation); a PASS 2/3 is shown with its failed trial, never as a clean pass. Reused results retain their original provenance and expiry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the first full paid /cso runtime qualification (evaluator run 38995081113, gstack e23f7b8), repairs never ran. Across 42 comprehensive cells the agent recorded 148 repair reviews, but no report has a verification-attempt event, and heldOutRepairEachStack scored 0/24 on every runtime row. Two stacked helper bugs caused it.
Read-only snapshot files.
preparePatchedSource(lib/cso/verification.ts) copies the snapshot, including its 0444 file modes, and then writes the patched file in place. For a non-root producer, which is how the evaluator and real users run, that write fails with EACCES. The CLI's catch-all then reports it as the generic "unexpected or unsafe input" error. The helper now makes an existing file owner-writable for the write and restores the original mode afterwards.Runtime profile alias.
runtime-planreturned the stack alias (node), and the skill tells the agent to copy that value into the verification request. Repair-bundle validation, however, requires the qualified runtime ID (node-24.4.0-amd64), so verify would still have failed once the first bug was fixed. Nowruntime-planreturns the full ID whenever the runtime catalog resolves one.verifyrejects any other profile with anINVALID_ARGUMENTthat names the expected ID, and it does so before an attempt is counted.Tests.
test/cso-contracts.test.ts: a new non-root regression test patches a 0444 snapshot file and checks that the mode is kept. It fails with EACCES without the fix.test/cso-node-lifecycle-integration.test.ts: now asserts thatruntime-planreturnscli.runtime.id, and builds the verification request from the plan's profile instead of hard-coding the runtime ID. That hard-coded ID is why the integration test never caught the alias bug.End-to-end check. The fix was also verified on a real qualification cell, running as
cso-producerwith a unit built under the CI-pinned Bun 1.4.2. The finding ended atrepair=runtime_testedandreproduction=reproduced.Checks:
bun run typecheck, andbun test test/cso-contracts.test.ts test/cso-cli.test.ts(81 pass). The Docker lifecycle suite needs a qualified node image and runs in the native validation lane.Unstamped; the version slot will come from GStack Minder.