Repository navigation
Conversation
…ble (garrytan#3168) Generated skills ship a ~1.8 KB "## Plan Mode Safe Operations" + "## Skill Invocation During Plan Mode" block on every skill, for hosts and users who never enter plan mode. This adds a --plan-mode=off flag to gen-skill-docs that drops that block at gen time. Default builds (planMode undefined or true) keep the block byte-identically. The "PLAN MODE EXCEPTION — ALWAYS RUN" markers inside skill bodies still apply when the flag is off.
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Triage (fix wave 5, GSTA-37): this adds a new generator flag for #3168, which is a feature request, so it's outside this bug-fix wave. I left it open for Garry's call. |
|
Thanks @xingzihai, this is a clean, well-tested change, and keeping default output byte-identical is exactly right. Decision: we want this, reworked so it's reachable from an installed gstack. Installed copies never run the generator, so a |
|
Thank you @xingzihai. Your flag was clean, well tested and byte-identical by default, and it's now the core of #3308. We went ahead and built the config wiring we asked about on the 17th, so this didn't have to wait on you: |
…preamble from installed skills (port of #3213) Merge origin/main and stamp 1.91.158.0. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…preamble from installed skills (port of #3213) (#3308) * feat(gen-skill-docs): add --plan-mode=off to omit the plan-mode preamble (#3168) Generated skills ship a ~1.8 KB "## Plan Mode Safe Operations" + "## Skill Invocation During Plan Mode" block on every skill, for hosts and users who never enter plan mode. This adds a --plan-mode=off flag to gen-skill-docs that drops that block at gen time. Default builds (planMode undefined or true) keep the block byte-identically. The "PLAN MODE EXCEPTION — ALWAYS RUN" markers inside skill bodies still apply when the flag is off. (cherry picked from commit 51edee9) * style(types): fix stray indentation on TemplateContext.installRoot Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * feat(config): plan_mode_preamble key wires --plan-mode=off into setup and every installed render gstack-config plan_mode_preamble (on|off, default on) makes ./setup pass --plan-mode=off to every gen:skill-docs render, gbrain-refresh and the gstack-relink router render. The default Claude install, which otherwise serves the committed SKILL.md files, gets a plain render with the key off; the activation record notes plan_mode=off so switching back on removes the render, including on the gbrain=unknown keep branch. With the key on or unset every path and record is byte-for-byte unchanged. Fixes #3168. Finishes #3213 by @xingzihai. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(setup,relink): plan_mode_preamble=off survives builds and failed renders; alias follows the router Review findings on the plan_mode_preamble wiring: - a build renders env hosts without --plan-mode=off, so with the key off setup no longer skips their re-render after a build; - with the key off the gbrain-absent branch leaves the render to the plain re-render, so a failed render keeps the previous one; - gstack-relink refreshes the _gstack-command alias after re-rendering the router (also fixes the same staleness for disabled_skills). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: xingzihai <xingzihai@users.noreply.github.com> Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Fixes #3168
What
Adds a
--plan-mode=offflag togen-skill-docsthat drops the ~1.8 KB "Plan Mode Safe Operations" + "Skill Invocation During Plan Mode" preamble block from every generated skill. Default builds (flag absent or--plan-mode=on) keep the block byte-identically.Live evidence
Liveness proof
Live command output above. The
--plan-mode=offflag is parsed ingen-skill-docs.ts, threaded throughGenerationOptions→RenderOptions→TemplateContext, and consumed ingenerate-completion-status.tswheregeneratePlanModeInforeturns''whenctx.planMode === false.