Skip to content

feat: add Cua Driver desktop QA - #2446

Closed
f-trycua wants to merge 1 commit into
garrytan:mainfrom
f-trycua:codex/desktop-qa-cua-driver
Closed

f-trycua wants to merge 1 commit into
garrytan:mainfrom
f-trycua:codex/desktop-qa-cua-driver

Conversation

@f-trycua

@f-trycua f-trycua commented Aug 3, 2026

Copy link
Copy Markdown

What

  • add /desktop-qa, a report-only workflow for one already-running native or Electron desktop window
  • use optional Cua Driver with strict window capture, exact PID/window binding, background-only actions, and fresh before/after verification
  • route desktop QA separately from browser and mobile QA
  • add documentation, cross-host generated skills, and deterministic contract coverage

Safety boundaries

This first version deliberately does not launch or quit apps, capture the desktop, foreground windows, install or update Cua Driver, grant permissions, edit source code, or fix findings. It requires synthetic or disposable data and explicit approval before external or persistent actions. If a background action cannot be verified, the report marks it unverified instead of widening permissions.

Prior art and overlap

Related prior art: #596. No implementation code was reused. This PR narrows the idea to an optional report-only desktop workflow and addresses the consent, full-display capture, unreviewed-app execution, and platform-scope concerns raised there. I also reviewed #604, #1574, #262, #2044, #1087, #1093, and #1754; none adds a general Cua Driver desktop QA skill.

Validation

  • bun test test/host-config.test.ts test/desktop-qa-contract.test.ts test/skill-coverage-matrix.test.ts test/skill-coverage-floor.test.ts test/skill-validation.test.ts test/skill-collision-sentinel.test.ts — 751 pass, 0 fail
  • bun run gen:skill-docs --host all --dry-run — all generated outputs fresh
  • bun run skill:check — new gstack-desktop-qa output accepted for every supported host and all host outputs fresh; command retains the existing top-level claude/SKILL.md missing-file exit on current main
  • Cua Driver 0.12.3 contract smoke — doctor healthy; strict window session started with desktop access locked and ended cleanly
  • full bun test was attempted; the change-owned golden fixture failures were fixed and retested. Remaining observed failures were unrelated environment/baseline failures, including unavailable XCTest and PATH-dependent gbrain fixtures.

Add a report-only, window-scoped desktop QA workflow with deterministic safety contract coverage. Prior art reviewed in garrytan#596; no implementation code was reused.
@trunk-io

trunk-io Bot commented Aug 3, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@f-trycua
f-trycua marked this pull request as ready for review August 4, 2026 12:27
@capy-ai

capy-ai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for this, @f-trycua, and for the work that went into it. We reviewed it against current main and decided not to take it: It ties a core routing line to one vendor's driver; a desktop-QA story should come from a host-native computer-use surface first. Closing it with thanks; if the underlying problem still bites you, an issue describing it is very welcome.

@capy-ai capy-ai Bot closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant