Repository navigation
Conversation
Add a report-only, window-scoped desktop QA workflow with deterministic safety contract coverage. Prior art reviewed in garrytan#596; no implementation code was reused.
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
f-trycua
marked this pull request as ready for review
August 4, 2026 12:27
Contributor
|
Thank you for this, @f-trycua, and for the work that went into it. We reviewed it against current main and decided not to take it: It ties a core routing line to one vendor's driver; a desktop-QA story should come from a host-native computer-use surface first. Closing it with thanks; if the underlying problem still bites you, an issue describing it is very welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/desktop-qa, a report-only workflow for one already-running native or Electron desktop windowSafety boundaries
This first version deliberately does not launch or quit apps, capture the desktop, foreground windows, install or update Cua Driver, grant permissions, edit source code, or fix findings. It requires synthetic or disposable data and explicit approval before external or persistent actions. If a background action cannot be verified, the report marks it unverified instead of widening permissions.
Prior art and overlap
Related prior art: #596. No implementation code was reused. This PR narrows the idea to an optional report-only desktop workflow and addresses the consent, full-display capture, unreviewed-app execution, and platform-scope concerns raised there. I also reviewed #604, #1574, #262, #2044, #1087, #1093, and #1754; none adds a general Cua Driver desktop QA skill.
Validation
bun test test/host-config.test.ts test/desktop-qa-contract.test.ts test/skill-coverage-matrix.test.ts test/skill-coverage-floor.test.ts test/skill-validation.test.ts test/skill-collision-sentinel.test.ts— 751 pass, 0 failbun run gen:skill-docs --host all --dry-run— all generated outputs freshbun run skill:check— newgstack-desktop-qaoutput accepted for every supported host and all host outputs fresh; command retains the existing top-levelclaude/SKILL.mdmissing-file exit on current mainbun testwas attempted; the change-owned golden fixture failures were fixed and retested. Remaining observed failures were unrelated environment/baseline failures, including unavailable XCTest and PATH-dependent gbrain fixtures.