Repository navigation
fix: upgrade diff to fix DoS vulnerability - #1172
Closed
yaoyunvfx-png wants to merge 1 commit into
Closed
yaoyunvfx-png wants to merge 1 commit into
yaoyunvfx-png wants to merge 1 commit into
Conversation
- Upgrade diff from 8.0.2 to 9.0.0 - Fixes GHSA-73rr-hh4g-fpgx (Denial of Service in parsePatch and applyPatch) - npm audit now shows 0 vulnerabilities
time-attack
pushed a commit
to time-attack/gstack
that referenced
this pull request
Jul 14, 2026
Reconstructs the shared fix from PRs garrytan#1599 and garrytan#1172 without their VERSION or npm lockfile changes.
Contributor
|
@16francej — recommend closing this PR. This is superseded by #1599, which handles the project lockfiles more completely. Unresolved security problems remain, and #1172 also introduces an outdated npm lockfile. Please preserve the advisory reporter’s attribution in #1599. |
Contributor
|
Thanks for this, @yaoyunvfx-png. The fix is now on main: package.json now depends on diff ^9.0.0 (already on main as of v1.91.16.0). Closing as superseded; if you still see the problem on the latest gstack, please open an issue with ./setup --status output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes security vulnerability in the diff (jsdiff) package.
Changes
Verification
This is a breaking change (major version bump) but necessary to fix the security issue.