Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced regex - keep track of position when matching instead #6

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mueslimak3r
Copy link

@mueslimak3r mueslimak3r commented Apr 4, 2022

Changes

  • replaced regex for turning list of matched frames -> start, end frames.
    Replaced by the frame matching logic having the frames just keep track of their own number.
    This should result in far fewer errors, and a marginal speedup

Issues

  • the regex used to take the matched frames and turn them into start and end frames was buggy and often resulted in the wrong start time.

Notes

  • sorry for all the edits. There was some weirdness with comparing branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant