Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README file #62

Closed
wants to merge 4 commits into from
Closed

Updated README file #62

wants to merge 4 commits into from

Conversation

Rishikeshrajrxl
Copy link
Contributor

Here I have added Contributors image in a formated manner. It looks wonderful now.

related to issue #57

Here I have added  some change in Contributors list. it looks wonder
@Rishikeshrajrxl
Copy link
Contributor Author

@garimasingh128, kindly review my PR

@garimasingh128
Copy link
Owner

Can you use a github action for this? Also you removed one of the contributors Mrinal from this.

@Rishikeshrajrxl
Copy link
Contributor Author

Rishikeshrajrxl commented Jan 2, 2021

Can you use a github action for this? Also you removed one of the contributors Mrinal from this.

@garimasingh128, there is no account to for Mrinal41298. Please check
and for regarding GitHub action, I think this is better all-contributor bot

@garimasingh128
Copy link
Owner

My fault sorry! It's @mrinal4
And all-contributors bot will work fine!

@Rishikeshrajrxl
Copy link
Contributor Author

@garimasingh128, what next then, should I do futher changes or simply close this PR

@garimasingh128
Copy link
Owner

You can try any github bot. For reference: https://github.com/saadpasta/developerFolio
We can't be using static readme contributors as of now.

@Rishikeshrajrxl
Copy link
Contributor Author

Rishikeshrajrxl commented Jan 3, 2021

@all-contributors please add @Rishikeshrajrxl for code

@Rishikeshrajrxl
Copy link
Contributor Author

@all-contributors please add @Rishikeshrajrxl for code

@garimasingh128
Copy link
Owner

Let me know if it works or i can set it up myself.

@m-code12
Copy link
Contributor

m-code12 commented Jan 4, 2021

@garimasingh128 Can you please install this bot on this repo, since only you have the permissions to do so. After that, I'll do the needful.
Also I have tested this bot on one of my personal repositories and it's working perfectly.

@garimasingh128
Copy link
Owner

ok i have installed

@m-code12
Copy link
Contributor

m-code12 commented Jan 4, 2021

@all-contributors please add @garimasingh128 for infrastructure, tests and code

@allcontributors
Copy link
Contributor

@m-code12

I've put up a pull request to add @garimasingh128! 🎉

@m-code12
Copy link
Contributor

m-code12 commented Jan 4, 2021

@all-contributors please add @gitter-badger for code

@allcontributors
Copy link
Contributor

@m-code12

I've put up a pull request to add @gitter-badger! 🎉

@m-code12
Copy link
Contributor

m-code12 commented Jan 4, 2021

@all-contributors please add @Rishikeshrajrxl for code

@garimasingh128
Copy link
Owner

Working fine I guess!

@allcontributors
Copy link
Contributor

@m-code12

I've put up a pull request to add @Rishikeshrajrxl! 🎉

@m-code12
Copy link
Contributor

m-code12 commented Jan 4, 2021

Working fine I guess!

Yes! 🚀

@m-code12
Copy link
Contributor

m-code12 commented Jan 4, 2021

I'll add all the contributors, please merge these pull requests.

@m-code12
Copy link
Contributor

m-code12 commented Jan 4, 2021

@all-contributors please add @Vishal-raj-1 for code

@allcontributors
Copy link
Contributor

@m-code12

I've put up a pull request to add @Vishal-raj-1! 🎉

@m-code12
Copy link
Contributor

m-code12 commented Jan 4, 2021

@all-contributors please add @m-code12 for code

@allcontributors
Copy link
Contributor

@m-code12

I've put up a pull request to add @m-code12! 🎉

@m-code12
Copy link
Contributor

m-code12 commented Jan 4, 2021

@garimasingh128 Should I remove this section then?
Screenshot (306)

@garimasingh128
Copy link
Owner

No, I will comment it out for now!

@garimasingh128
Copy link
Owner

If I am adding someone its showing This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 364
Can u check?

@m-code12
Copy link
Contributor

m-code12 commented Jan 4, 2021

@garimasingh128
Please update my points on the leaderboard for resolving this issue. Thanks :)

@garimasingh128
Copy link
Owner

Yup sure, I will update the points. I tried for other contributors and its working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants