Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not current fully function. This PR is the bare minimum number of changes to
2 failure types remain:
ImportError: Building module gryphon.execution.harness.harness failed: ['ImportError: Building module gryphon.execution.harness.exchange_coordinator failed: ["ModuleNotFoundError: No module named \'monkeypatch_timeit\'\\n"]\n']
AttributeError: module 're' has no attribute '_pattern_type'
The latter would need to be fixed by upgrading to a newer version of
sure
as_pattern_type
was dropped from 3.7 in favor ofre.Pattern
One other concern is the removal of
line_profiler
which also seems to have a known issue, see rkern/line_profiler#132My belief is that this is a good starting point for others (and myself) to continue working on python3 support