Attach PDF to release #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Feb 26, 2021
| -H "Accept: application/vnd.github.v3+json" \ | ||
| -H "Authorization: token $TOKEN" \ | ||
| -H "Content-Type: application/pdf" \ | ||
| --data-binary @"$FULLNAME") |
There was a problem hiding this comment.
It'd be nicer if that upload code was in a function which gets called with the filename and mime type (and the logname could just be $TMP_DIR/${filename}.log.
Even nicer would be to write all of this hellish shell code in e.g. Python 😂
Needless to say, I don't expect you to do either of these, just had to get it off my chest (the current state is my fault, of course)
Yes, the code is actually from last october. I just did not want to open too many PRs and have to rebase everything all the time :D Now all changes I have are merged :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69.
We have already tested this in production: https://github.com/homalg-project/homalg_project/releases