Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: release fails for packages with multiple manuals / where PackageDoc is a list #81

Closed
fingolfin opened this issue Apr 13, 2021 · 0 comments

Comments

@fingolfin
Copy link
Member

In PR #79 @zickgraf implemented attaching "the" manual PDF to a release.

Unfortunately, this lead to a regression, because there are packages which have multiple manuals; hence PackageDoc can be a record or a list of records. Thus this line can run into an error:

Print("PDFFile=\"",GAPInfo.PackageInfoCurrent.PackageDoc.PDFFile,"\"\n");

The immediate workaround would be to use something like this:

r := GAPInfo.PackageInfoCurrent.PackageDoc.PDFFile;;
if IsList(r) then r:=r[1]; fi;
Print("PDFFile=\"",r,"\"\n");

However, that would then only upload the "first" PDF; but what if there are multiple manuals, each with a PDF? Perhaps we should upload them all? I guess one could try to set PDFFile to a bash array of manual names...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant