RJT new #55
Merged
RJT new #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solliolli
reviewed
Aug 23, 2024
solliolli
reviewed
Aug 23, 2024
solliolli
reviewed
Aug 23, 2024
solliolli
reviewed
Aug 23, 2024
solliolli
reviewed
Aug 23, 2024
src/decision_model.jl
Outdated
| """ | ||
| function RJTVariables(model::Model, diagram::InfluenceDiagram, z::OrderedDict{Name, DecisionVariable}) | ||
| # Get the RJT structure | ||
| # SHOULD WE DEFINE C_rjt and A_rjt AS PART OF THE INFLUENCE DIAGRAM STRUCT OR AS THEIR OWN, MAYBE BETTER TO DEFINE AS PART OF INFLUENCE DIAGRAM IF THERE IS NEVER A NEED |
There was a problem hiding this comment.
I think it makes sense for them to be independent
There was a problem hiding this comment.
If we make them independent, they need to be passed as arguments to several functions, where diagram is already passed as an argument. Is it worth it, what do you think?
solliolli
reviewed
Aug 23, 2024
solliolli
reviewed
Aug 27, 2024
examples/pig_breeding.jl
Outdated
|
|
||
| @info("Starting the optimization process.") | ||
| optimizer = optimizer_with_attributes( | ||
| () -> HiGHS.Optimizer() | ||
| ) | ||
| set_optimizer(model, optimizer) | ||
|
|
||
| spu = singlePolicyUpdate(diagram, model, z, x_s) | ||
| println(variables==x_s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New RJT pull request