-
Notifications
You must be signed in to change notification settings - Fork 48
Epic/rupee sanity #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
viccie211
wants to merge
128
commits into
gamestabled:main
Choose a base branch
from
viccie211:epic/rupee-sanity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Epic/rupee sanity #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/first-rupee
Places vanilla items for the rupees if off and adds the non respawning rupees to the item pool when on
Developers please rebase to avoid merge conflicts!
…upee # Conflicts: # code/src/item_override.c
Developers please rebase to avoid merge conflicts!
Developers please rebase to avoid merge conflicts!
…_Randomizer into feature/some-more-rupees
# Conflicts: # code/src/hooks.s # code/src/patches.s # code/src/savefile.c
We cannot set rupee parent because spawner actor detects it to set a permanent switch flag
Developers please rebase to avoid merge conflicts!
Fix bug with rupee circle
Feature/hints
Code formatting
Merge upstream branch
To fix a bug where multiple rupee circle items could be picked up while in the air filling up the queue and deleting the items that would fall out of the queue
Developers please rebase to avoid merge conflicts!
- move rupeesanity flags to ExtInf; - destroy model if flag is set;
Simpler multiplayer implementation
Developers please rebase to avoid merge conflicts!
Feature/mq rupee sanity
Fix multiplayer sync issue
Rupeesanity hints: some fixes + Italian translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Rupeesanity option to the shuffle options.
Rupeesanity shuffles all freestanding visible rupees that are placed in the world without player intervention. So it does include rupees that are placed in other object like boulders, but it doesn't include Wonder Items or rupees that spawn from the goron city spinning pot or the pots in Shadow Temple.
Rupeesanity adds the following checks:
Kokiri Forest
Lost Woods
Graveyard
Death Mountain Trail
Death Mountain Crater
Zora's River
Zora's Fountain
Lake Hylia
Gerudo Valley
Bottom of the Well
Ice Cavern
Jabu Jabu's Belly MQ
Again thanks to Gymnast, Nessy, Hylian Freddy and Kewlan!