Fix: Make new location for Triforce Hunt goal #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kewlan
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with the Triforce Hunt playthrough calculation that can cause it to include useless items.
Currently, the win condition for Triforce Hunt is implemented by having the Ganon location (which contains the placeholder Triforce item to represent game end) accessible from the
ROOTArea when all the pieces have been collected. But the parent region for the Ganon location is still Ganon's Tower. This leads to the playthrough calculations not considering it reachable from the root Area even after collecting all Triforce Pieces because the age/time variables in the Ganon's Tower Area aren't updated yet, makingLocationAccess::ConditionsMet()always return false.The result is that the playthrough (and everything depending on it like the gossip stone hints with the Playthrough distribution) could end up with many more useless steps and spheres after the last Triforce Piece.
To fix this, I added another location for the Triforce Hunt win condition, which is correctly assigned exclusively to the
ROOTparent region, and made the relevant adjustments where needed to make it work as the goal while keeping the Ganon location accessible.