Open
Conversation
added 8 commits
January 9, 2016 22:58
Collaborator
|
Thanks for contributing! I'll wait with any feedback, until you are done applying commits (8 yesterday, 3 new today). In the future, please wait until you are done coding before sending a pull request. It's kind of annoying when code is changing while reading it. |
Author
|
Sure, thats a good point. Sorry for that. Done with this round of changes (was going to commit todays changes to a new branch though). So ill open a new branch/PR with feedback and or discovered bugs / issues. |
Collaborator
|
Sounds good :) I'll take a look at your pull request as soon as I get the chance. |
Open
Author
|
Have you had a chance to take alook at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support to publish log entries on a redis channel. Not sure if everything is up to styling / convention, and probably some stuff needs work. Looking forward to feedback.