Fix most new vue typescript errors discovered in #19851 #19862
Merged
+33
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/History/Layout/DetailsLayout.vue:98:9 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
Type 'undefined' is not assignable to type 'string'.
98 name: props.name,
~~~~
src/components/History/Layout/DetailsLayout.vue:99:9 - error TS2322: Type 'string | undefined' is not assignable to type 'string | null'.
Type 'undefined' is not assignable to type 'string | null'.
99 annotation: props.annotation,
~~~~~~~~~~
src/components/History/Layout/DetailsLayout.vue:47:40
47 const localProps = ref<{ name: string; annotation: string | null; tags: string[] }>({
~~~~~~~~~~
The expected type comes from property 'annotation' which is declared here on type '{ name: string; annotation: string | null; tags: string[]; }'
src/components/History/Layout/DetailsLayout.vue:100:9 - error TS2322: Type 'string[] | undefined' is not assignable to type 'string[]'.
Type 'undefined' is not assignable to type 'string[]'.
100 tags: props.tags,
~~~~
src/components/History/Layout/DetailsLayout.vue:47:67
47 const localProps = ref<{ name: string; annotation: string | null; tags: string[] }>({
~~~~
The expected type comes from property 'tags' which is declared here on type '{ name: string; annotation: string | null; tags: string[]; }'
src/components/History/Layout/DetailsLayout.vue:124:17 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
Type 'undefined' is not assignable to type 'string'.
124 v-model="clickToEditName"
~~~~~~~
src/components/Collections/common/ClickToEdit.vue:8:5
8 value: string;
~~~~~
The expected type comes from property 'value' which is declared here on type 'Readonly<Partial<{}> & Omit<Readonly<ExtractPropTypes<__VLS_TypePropsToOption<Props>>>, never>> & Record<...>'
src/components/Login/LoginForm.vue:84:9 - error TS2322: Type 'string | undefined' is not assignable to type 'string | null'.
Type 'undefined' is not assignable to type 'string | null'.
84 redirect = props.redirect;
~~~~~~~~
src/components/Markdown/MarkdownDialog.vue:133:73 - error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
133 ["history_dataset_id", "history_dataset_collection_id"].indexOf(props.argumentType) >= 0 ? "output" : "step";
~~~~~~~~~~~~~~~~~~
src/components/User/DiskUsage/Management/Cleanup/CleanupResultDialog.vue:28:16 - error TS18048: 'props.result' is possibly 'undefined'.
28 } else if (props.result.isPartialSuccess) {
~~~~~~~~~~~~
src/components/User/DiskUsage/Management/Cleanup/CleanupResultDialog.vue:30:16 - error TS18048: 'props.result' is possibly 'undefined'.
30 } else if (props.result.success) {
~~~~~~~~~~~~
src/components/User/DiskUsage/Management/Cleanup/ReviewCleanupDialog.vue:168:30 - error TS18048: 'props.operation' is possibly 'undefined'.
168 const result = await props.operation.fetchItems(options);
~~~~~~~~~~~~~~~
src/components/User/DiskUsage/Management/Cleanup/ReviewCleanupDialog.vue:177:28 - error TS18048: 'props.operation' is possibly 'undefined'.
177 const allItems = await props.operation.fetchItems(
~~~~~~~~~~~~~~~
src/components/Workflow/Run/WorkflowRunFormSimple.vue:267:34 - error TS2322: Type 'string | null' is not assignable to type 'string | undefined'.
Type 'null' is not assignable to type 'string | undefined'.
267 :invocation-preferred-object-store-id="preferredObjectStoreId"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/components/Workflow/Run/WorkflowStorageConfiguration.vue:65:9
65 invocationPreferredObjectStoreId: {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
66 type: String,
~~~~~~~~~~~~~~~~~~~~~~~~~
67 default: null,
~~~~~~~~~~~~~~~~~~~~~~~~~~
68 },
~~~~~~~~~
jmchilton
changed the title
ElectronicBlueberry
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dannon updated the dependencies in #19851 and it discovered more Vue typescript typing errors. I think this should fix those. Also one follow up for a single error remaining after the Dataset Source modeling stuff #19666.
How to test the changes?
(Select all options that apply)
License