release: prepare v1.7.2#89
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
More reviews will be available in 42 minutes and 30 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR bundles multiple preparation tasks for SwiftASB v1.7.2: it transitions licensing from Apache 2.0 to PolyForm Noncommercial, updates Codex CLI compatibility window to 0.138.x, introduces a new AppKit thread sidebar UI, refactors ReasoningEffort wire types, and updates release infrastructure to support checked-in release notes files. ChangesSwiftASB v1.7.2 Release and Codex CLI 0.138.x Compatibility Update
🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly Related PRs
Suggested Labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 26: Update the README statement that currently asserts "v1.7.2 is the
current and latest release" to avoid claiming an unshipped release—modify the
sentence containing "SwiftASB is actively maintained and supported by Gale" and
the `v1.7.2` reference to a qualified form such as "v1.7.2 is being prepared as
the next release" or remove the release claim entirely so documentation reflects
only shipped versions.
In `@Sources/ASBAppKit/ASBThreadSidebarView.swift`:
- Around line 238-282: ASBThreadSidebarRow is unnecessarily exported; make it
internal by removing the public access modifier from the class declaration and
its members so it is not part of the module's public API. Update the declaration
of ASBThreadSidebarRow (and its initializers init(section:) and init(item:),
properties id, kind, title, subtitle, threadItem, children, and the private
static subtitle(for:) helper if marked public) to use the default internal
visibility (remove "public"), keeping the class as final and `@MainActor` as-is.
Ensure no other files require it to be public before changing visibility.
- Around line 193-236: The ASBThreadSidebarAdapter and its exposed members
(e.g., ASBThreadSidebarAdapter class declaration, columnIdentifier, sections,
init, apply, flattenedRows, row(forThreadID:), numberOfChildren(of:),
child(_:of:), isExpandable(_:)) should be made internal to reduce the framework
API surface; change the class access from public to internal (remove public) and
likewise remove public from its properties and methods so only internal
visibility is used (keeping `@MainActor` and functionality unchanged).
In `@Sources/SwiftASB/Public/CodexAppServer`+WireMapping.swift:
- Around line 489-500: The wire mapping currently maps unknown inbound strings
to the sentinel case .unrecognized and then serializes that sentinel back as the
literal "unrecognized"; update the CodexAppServer.ReasoningEffort mapping so the
original unknown string is preserved instead of being lost: change the enum to
carry the original string for unknown values (e.g., unrecognized(String)),
update init(wireValue: String) and init?(wireValue: String?) to construct
.unrecognized(originalString) when the rawValue initializer fails, and update
var wireValue to return the original unknown string for the unrecognized case
(and the normal rawValue for known cases) so we never emit the literal
"unrecognized" onto the wire.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 27ac541e-9ab2-479c-8a65-4edeec763ef5
⛔ Files ignored due to path filters (1)
Sources/SwiftASB/Generated/CodexWire/Latest/CodexLifecycleV2Batch+JSONValue.swiftis excluded by!**/generated/**
📒 Files selected for processing (33)
COMMERCIAL-USE.mdCONTRIBUTING.mdLICENSELICENSE-APACHE-2.0NOTICEREADME.mdROADMAP.mdSources/ASBAppKit/ASBAppKitModule.swiftSources/ASBAppKit/ASBThreadSidebarView.swiftSources/SwiftASB/Public/CodexAppServer+CodexExtensions.swiftSources/SwiftASB/Public/CodexAppServer+Compatibility.swiftSources/SwiftASB/Public/CodexAppServer+WireMapping.swiftSources/SwiftASB/Transport/CodexCLIExecutableResolver.swiftTests/ASBAppKitTests/ASBAppKitModuleTests.swiftTests/ASBAppKitTests/ASBThreadSidebarViewTests.swiftTests/SwiftASBTests/Protocol/CodexAppServerProtocolTests.swiftTests/SwiftASBTests/Public/CodexAppServerLiveIntegrationTests.swiftTests/SwiftASBTests/Public/CodexAppServerTestSupport.swiftTests/SwiftASBTests/Public/CodexAppServerTests.swiftTests/SwiftASBTests/Transport/CodexCLIExecutableResolverTests.swiftTools/AgentSB/pyproject.tomlTools/AgentSB/tests/test_cli.pyTools/AgentSB/tests/test_tools.pydocs/agents/reports/2026-06-09-agentsb-maintenance-draft.mddocs/agents/reports/2026-06-09-agentsb-schema-review.mddocs/maintainers/interactive-lifecycle-release-boundary.mddocs/maintainers/presentation-ui-targets-plan.mddocs/maintainers/v1-public-api-audit.mddocs/releases/v1.7.2.mdscripts/generate-wire-types.shscripts/repo-maintenance/lib/common.shscripts/repo-maintenance/release.shscripts/repo-maintenance/release/40-github-release.sh
💤 Files with no reviewable changes (2)
- Tests/ASBAppKitTests/ASBAppKitModuleTests.swift
- Sources/ASBAppKit/ASBAppKitModule.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release
maintenance/codex-schema-refreshmainupdates behind pull request review and CIv1.7.2will be created after CI and the review-comment gate pass, so failed or still-discussed release candidates do not get taggedReview Loop
Before merge and tagging,
scripts/repo-maintenance/release.shwatches CI and stops on review comments unless the maintainer has already addressed or resolved them and reruns with--review-comments-addressed.