docs: update models.md with missing fields#6
Open
mahek56 wants to merge 1 commit into
Open
Conversation
gabrielgz0
reviewed
May 27, 2026
Owner
There was a problem hiding this comment.
Hi @mahek56, thanks for the contribution. The PR looks great. You covered all the fields from issue #3. Clean diff, only the right file was modified.
Two small corrections from the source code:
1. Ata.orgao_uf wrong alias
Code at src/pypncp/models.py:288:
orgao_uf: str | None = None
No Field, no alias. ufSigla does not exist for this field. Remove the alias column or leave it blank.
2. SearchResult.numero_sequencial wrong type
Code at src/pypncp/models.py:328:
numero_sequencial: str = Field(default="", alias="numero_sequencial")
It is str, not int | None. Default is an empty string.
Other than that, its perfect. Fix these two and I will approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated docs/models.md to include missing fields for the following models:
numero_controle_pncp_ata, informacao_complementar, data_atualizacao_global
situacao, unidade_nome, orgao_uf, data_atualizacao_global
tipo_nome, tipo_contrato_nome, exigencia_conteudo_nacional
Closes #3