Upgrade solution to .NET Standard 2.0 #36
+95
−171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded the solution to the new projects and used .NET Standard 2.0. I tested that it can install to ASP.NET Core 2.0 project as well as to .NET Framework 4.6.1 project. I am using this in my project and it works fine.
I also did not find aby recommended deployment model to publish packages for .NET Standard 1.x and .NET Standard 2.0. So I did what MSFT did and changed the version of your package to 2.0.0.
The problematic part is tests, I don't have experience making nUnit tests work with VS as I always use xUnit, so maybe you can fix this much quicker. The tests run fine through re-sharper test runner (one of them fails, but it also failed for me even before I started migrating). Normal VS Test runner does not detect the tests for me.
I tried making the test projects .NET Core, but it does not run the tests, and I cannot find a runner for nUnit and .NET Core 2.0 (did not try the console, because I think you already have some workflow that I don't want to break). So I ended up with projects that are net461 and autogenerate bindings to libraries otherwise you will get a lot of Cannot load assembly errors).
Fix #34
Fix #35