Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade solution to .NET Standard 2.0 #36

Open
wants to merge 1 commit into
base: netcore
Choose a base branch
from

Conversation

nohwnd
Copy link

@nohwnd nohwnd commented Sep 18, 2017

🔥 You don't want to merge this as you would lose compatibility with .NET Core 1.x. Instead you need to adopt this branch :)

I upgraded the solution to the new projects and used .NET Standard 2.0. I tested that it can install to ASP.NET Core 2.0 project as well as to .NET Framework 4.6.1 project. I am using this in my project and it works fine.

I also did not find aby recommended deployment model to publish packages for .NET Standard 1.x and .NET Standard 2.0. So I did what MSFT did and changed the version of your package to 2.0.0.

The problematic part is tests, I don't have experience making nUnit tests work with VS as I always use xUnit, so maybe you can fix this much quicker. The tests run fine through re-sharper test runner (one of them fails, but it also failed for me even before I started migrating). Normal VS Test runner does not detect the tests for me.

I tried making the test projects .NET Core, but it does not run the tests, and I cannot find a runner for nUnit and .NET Core 2.0 (did not try the console, because I think you already have some workflow that I don't want to break). So I ended up with projects that are net461 and autogenerate bindings to libraries otherwise you will get a lot of Cannot load assembly errors).

image

Fix #34
Fix #35

@razzeee
Copy link

razzeee commented Sep 27, 2017

Might be a good idea to also add a global.json? https://docs.microsoft.com/en-us/dotnet/core/tools/global-json

@razzeee
Copy link

razzeee commented Oct 9, 2017

@g0t4 would be awesome to get this going and released in some form, pretty much waiting for this :/

@ajtatum
Copy link

ajtatum commented Oct 19, 2017

@g0t4 thank you for writing this out. Do you have an idea when this branch will be merged/released? Thank you!

@razzeee
Copy link

razzeee commented Nov 9, 2017

Any progress on this? This is blocking us from porting the last component to dotnet2.0.
Would be great to get this package updated, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants