Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hash.hpp to detect msvc #1262

Closed
wants to merge 1 commit into from
Closed

Conversation

abrady
Copy link

@abrady abrady commented Feb 20, 2024

this causes errors when building on windows with cl:

[proc] Executing command: "C:\Program Files\CMake\bin\cmake.EXE" --build c:/open/Github/Vulk/build --config Debug --target PipelineBuilder -j 66 --
[build] MSBuild version 17.8.3+195e7f5a3 for .NET Framework
[build] 
[build]   Checking File Globs
[build]   Vulk.cpp
[build]   GLM_GTX_hash requires C++11 standard library support
[build]   VulkActor.cpp
[build]   GLM_GTX_hash requires C++11 standard library support
[build]   VulkCamera.cpp
[build]   GLM_GTX_hash requires C++11 standard library support
...

This change appears to fix it:

[proc] Executing command: "C:\Program Files\CMake\bin\cmake.EXE" --build c:/open/Github/Vulk/build --config Debug --target PipelineBuilder -j 66 --
[build] MSBuild version 17.8.3+195e7f5a3 for .NET Framework
[build] 
[build]   Checking File Globs
[build]   Vulk.cpp
[build]   VulkActor.cpp
[build]   VulkCamera.cpp

check out https://github.com/abrady/Vulk if you want to repro.

this causes errors when building on windows with cl
@christophe-lunarg christophe-lunarg mentioned this pull request Mar 5, 2024
@christophe-lunarg
Copy link

This is resolved with #1274 thanks for contributing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants