Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new callback-based settings listener API #5431

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add new callback-based settings listener API #5431

wants to merge 5 commits into from
+85 −50

Conversation

dweymouth
Copy link
Contributor

Description:

The existing Settings.AddChangeListener needs to be deprecated, since it is channel-based, and user code cannot block on channel receives from the main thread, and communicating to user code via a goroutine is against the new threading model.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.
  • Any breaking changes have a deprecation path or have been discussed.

@andydotxyz
Copy link
Member

Not to sure how to resolve the conflict through web UI sorry @dweymouth

@dweymouth dweymouth marked this pull request as ready for review January 20, 2025 12:38
@coveralls
Copy link

Coverage Status

coverage: 59.055% (+0.01%) from 59.043%
when pulling 05d8bbb on dweymouth:settings-callback
into 351aebe on fyne-io:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweymouth @andydotxyz @coveralls