Remove closed windows in place without allocating a new slice #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted by Drew, we should not tick animations and draw the frame once for every window available. This would make us slower the more windows you have and tick animations too fast. Co-authored-by: Drew Weymouth <[email protected]>
|
Looks like a race or two opened up in the tests |
|
The race seems like the same one I fixed in the other PR, I think |
Ah, perhaps - let's get that in and rebase to make sure. |
|
The race does indeed look to be the same :) |
andydotxyz
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Just a small improvement that I noticed could be done, thanks to everything happening on one thread, while working on #5422. Will give a bit of a merge conflict but this seems to make more sense separately (especially if that for some reason wouldn't be ready in time for 2.6).
This also includes a fix from Drew from the same PR to address window repaints and animation ticking happening once for every window on each frame tick. We were basically doing a frame render
O(n^2)times, where n is amount of visible windows.Checklist: