Close G5b: Hybrid XDP detach detection - #24
Merged
Merged
Conversation
Attach the admit-shed via netlink so IFLA_XDP remains visible, and fail Hybrid back to the userspace bucket when ip link xdp off clears the program id.
ip link xdp off only clears driver mode; use xdpgeneric off (and matching netlink flags) when the shed attached via SKB fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attach the XDP admit-shed via netlink so it stays visible to
IFLA_XDP/ip link(and detachable withip link set … xdp off).link_alive()checks iface existence and the current XDP program id; Hybrid RCU heartbeat drops the shed and falls back to the userspace bucket on detach/replace.Veth smoke coverage for admin
xdp off; threat-model G5b marked mitigated.I have read CLA.md and certify my contribution under Apache-2.0 OR MIT
Test plan
cargo check -p demiurge-dataplane -p demiurge-router./scripts/xdp-veth-smoke.sh(includesxdp_admit_shed_detects_admin_xdp_off)