Skip to content

Use aerosol_is instead of is_bulk - #7

Merged
fvitt merged 2 commits into
fvitt:bam_opticsfrom
gold2718:bam_optics
Dec 4, 2025
Merged

Use aerosol_is instead of is_bulk#7
fvitt merged 2 commits into
fvitt:bam_opticsfrom
gold2718:bam_optics

Conversation

@gold2718

@gold2718 gold2718 commented Dec 3, 2025

Copy link
Copy Markdown

I need to run some tests but this is my entry-level version of what can be done now and I think should be okay as is.

@fvitt

fvitt commented Dec 4, 2025

Copy link
Copy Markdown
Owner

@gold2718 This looks okay to me. I will do a quick test on ACOM's modeling2 using your fork/branch.

@fvitt

fvitt commented Dec 4, 2025

Copy link
Copy Markdown
Owner

I am having some compile errors. Would I be able to push to your fork/branch? Otherwise, I could merge in your mods as is and fix the issues in my branch..

@gold2718

gold2718 commented Dec 4, 2025

Copy link
Copy Markdown
Author

I am having some compile errors. Would I be able to push to your fork/branch? Otherwise, I could merge in your mods as is and fix the issues in my branch..

I sent you an invite to my fork (in case you need it to push).

	modified:   src/chemistry/aerosol/aerosol_properties_mod.F90
	modified:   src/chemistry/aerosol/bulk_aerosol_properties_mod.F90
	modified:   src/chemistry/aerosol/carma_aerosol_properties_mod.F90
	modified:   src/chemistry/aerosol/modal_aerosol_properties_mod.F90
@fvitt
fvitt merged commit ab80ee3 into fvitt:bam_optics Dec 4, 2025
2 checks passed
@gold2718
gold2718 deleted the bam_optics branch December 5, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants